Skip to content

CI: Upgrade checkout to v4, add PR triggers#146

Merged
0xLeif merged 2 commits into0xLeif:mainfrom
corvid-agent:ci/upgrade-checkout-add-pr-triggers
Feb 28, 2026
Merged

CI: Upgrade checkout to v4, add PR triggers#146
0xLeif merged 2 commits into0xLeif:mainfrom
corvid-agent:ci/upgrade-checkout-add-pr-triggers

Conversation

@corvid-agent
Copy link
Copy Markdown
Contributor

Summary

  • Upgrades actions/checkout from v3 to v4 in docc, macOS, and ubuntu workflows (windows already had v4)
  • Adds pull_request triggers (targeting main) to all build/test workflows (macOS, ubuntu, windows)
  • DocC workflow remains push-to-main only since it deploys to GitHub Pages

Closes #145

Test plan

  • macOS CI passes on this PR
  • Ubuntu CI passes on this PR
  • Windows CI passes on this PR

🤖 Generated with Claude Code

- Upgrade actions/checkout from v3 to v4 in docc, macOS, and ubuntu workflows
- Add pull_request triggers to macOS, ubuntu, and windows CI workflows
- docc workflow kept as push-to-main only (deploys to Pages)

Closes 0xLeif#145

Co-Authored-By: corvid-agent <corvid-agent@users.noreply.github.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Narrows push trigger from all branches to main only. PRs targeting
main are now covered solely by the pull_request trigger, preventing
duplicate CI runs on every push to a PR branch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@corvid-agent
Copy link
Copy Markdown
Contributor Author

Good catch — you're right, push: branches: ["**"] plus pull_request: branches: ["main"] would double-trigger on every push to a PR branch targeting main.

Fixed in 1a8edd8: scoped the push trigger to ["main"] only across all three workflow files (macOS, Ubuntu, Windows). Now push fires once on merge to main, and pull_request handles PR validation — no overlap.

@0xLeif 0xLeif merged commit 0a58ece into 0xLeif:main Feb 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Upgrade actions/checkout to v4 and add pull_request triggers

2 participants