Skip to content

chore: bring release/v0.14.0-alpha.9 changes to next #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmagician wants to merge 4 commits into
base: next
Choose a base branch
from
+252 −45
Open

chore: bring release/v0.14.0-alpha.9 changes to next #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bce00da
fix(store): handle AllEntries pagination for genesis block storage ma…
mmagician Mar 23, 2026
e68176e
chore: bump version to `0.14.0-alpha.9` (#1821)
mmagician Mar 23, 2026
24c475c
fix: correctly return `LimitExceeded` from `reconstruct_storage_map_f…
mmagician Mar 23, 2026
1e852ad
Merge branch 'next' into release/v0.14.0-alpha
igamigo Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
- Fixed `bundled bootstrap` requiring `--validator.key.hex` or `--validator.key.kms-id` despite a default key being configured ([#1732](https://github.com/0xMiden/node/pull/1732)).
- Fixed incorrectly classifying private notes with the network attachment as network notes ([#1378](https://github.com/0xMiden/node/pull/1738)).
- Fixed accept header version negotiation rejecting all pre-release versions; pre-release label matching is now lenient, accepting any numeric suffix within the same label (e.g. `alpha.3` accepts `alpha.1`) ([#1755](https://github.com/0xMiden/node/pull/1755)).
- Fixed `GetAccount` returning an internal error for `AllEntries` requests on storage maps where all entries are in a single block (e.g. genesis accounts) ([#1816](https://github.com/0xMiden/node/pull/1816)).
- Fixed `GetAccount` returning empty storage map entries instead of `too_many_entries` when a genesis account's map exceeds the pagination limit ([#1816](https://github.com/0xMiden/node/pull/1816)).

## v0.13.8 (2026-03-12)

Expand Down
36 changes: 18 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ license = "MIT"
readme = "README.md"
repository = "https://github.com/0xMiden/node"
rust-version = "1.93"
version = "0.14.0-alpha.8"
version = "0.14.0-alpha.10"

# Optimize the cryptography for faster tests involving account creation.
[profile.test.package.miden-crypto]
Expand All @@ -47,22 +47,22 @@ debug = true

[workspace.dependencies]
# Workspace crates.
miden-large-smt-backend-rocksdb = { path = "crates/large-smt-backend-rocksdb", version = "=0.14.0-alpha.8" }
miden-node-block-producer = { path = "crates/block-producer", version = "=0.14.0-alpha.8" }
miden-node-db = { path = "crates/db", version = "=0.14.0-alpha.8" }
miden-node-grpc-error-macro = { path = "crates/grpc-error-macro", version = "=0.14.0-alpha.8" }
miden-node-ntx-builder = { path = "crates/ntx-builder", version = "=0.14.0-alpha.8" }
miden-node-proto = { path = "crates/proto", version = "=0.14.0-alpha.8" }
miden-node-proto-build = { path = "proto", version = "=0.14.0-alpha.8" }
miden-node-rpc = { path = "crates/rpc", version = "=0.14.0-alpha.8" }
miden-node-store = { path = "crates/store", version = "=0.14.0-alpha.8" }
miden-large-smt-backend-rocksdb = { path = "crates/large-smt-backend-rocksdb", version = "=0.14.0-alpha.10" }
miden-node-block-producer = { path = "crates/block-producer", version = "=0.14.0-alpha.10" }
miden-node-db = { path = "crates/db", version = "=0.14.0-alpha.10" }
miden-node-grpc-error-macro = { path = "crates/grpc-error-macro", version = "=0.14.0-alpha.10" }
miden-node-ntx-builder = { path = "crates/ntx-builder", version = "=0.14.0-alpha.10" }
miden-node-proto = { path = "crates/proto", version = "=0.14.0-alpha.10" }
miden-node-proto-build = { path = "proto", version = "=0.14.0-alpha.10" }
miden-node-rpc = { path = "crates/rpc", version = "=0.14.0-alpha.10" }
miden-node-store = { path = "crates/store", version = "=0.14.0-alpha.10" }
miden-node-test-macro = { path = "crates/test-macro" }
miden-node-utils = { path = "crates/utils", version = "=0.14.0-alpha.8" }
miden-node-validator = { path = "crates/validator", version = "=0.14.0-alpha.8" }
miden-remote-prover-client = { path = "crates/remote-prover-client", version = "=0.14.0-alpha.8" }
miden-node-utils = { path = "crates/utils", version = "=0.14.0-alpha.10" }
miden-node-validator = { path = "crates/validator", version = "=0.14.0-alpha.10" }
miden-remote-prover-client = { path = "crates/remote-prover-client", version = "=0.14.0-alpha.10" }
# Temporary workaround until <https://github.com/rust-rocksdb/rust-rocksdb/pull/1029>
# is part of `rocksdb-rust` release
miden-node-rocksdb-cxx-linkage-fix = { path = "crates/rocksdb-cxx-linkage-fix", version = "=0.14.0-alpha.8" }
miden-node-rocksdb-cxx-linkage-fix = { path = "crates/rocksdb-cxx-linkage-fix", version = "=0.14.0-alpha.10" }

# miden-base aka protocol dependencies. These should be updated in sync.
miden-block-prover = { version = "=0.14.0-alpha.2" }
Expand Down
6 changes: 6 additions & 0 deletions crates/store/src/db/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,12 @@ impl Db {
values.extend(page.values);
let mut last_block_included = page.last_block_included;

// If the first page returned no values, the block at block_range_start has more
// entries than the limit allows (e.g. genesis accounts with large storage maps).
if values.is_empty() && last_block_included == block_range_start {
return Ok(AccountStorageMapDetails::limit_exceeded(slot_name));
}

loop {
if page.last_block_included == block_num || page.last_block_included < block_range_start
{
Expand Down
23 changes: 10 additions & 13 deletions crates/store/src/db/models/queries/accounts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,21 +468,20 @@ pub(crate) fn select_account_vault_assets(
.limit(i64::try_from(MAX_ROWS + 1).expect("should fit within i64"))
.load::<(i64, Vec<u8>, Option<Vec<u8>>)>(conn)?;

// Discard the last block in the response (assumes more than one block may be present)
// If we got more rows than the limit, the last block may be incomplete so we
// drop it entirely and derive last_block_included from the remaining rows.
let (last_block_included, values) = if let Some(&(last_block_num, ..)) = raw.last()
&& raw.len() > MAX_ROWS
{
// NOTE: If the query contains at least one more row than the amount of storage map updates
// allowed in a single block for an account, then the response is guaranteed to have at
// least two blocks

let values = raw
.into_iter()
.take_while(|(bn, ..)| *bn != last_block_num)
.map(AccountVaultValue::from_raw_row)
.collect::<Result<Vec<_>, DatabaseError>>()?;

(BlockNumber::from_raw_sql(last_block_num.saturating_sub(1))?, values)
let last_block_included = values.last().map_or(*block_range.start(), |v| v.block_num);

(last_block_included, values)
} else {
(
*block_range.end(),
Expand Down Expand Up @@ -716,22 +715,20 @@ pub(crate) fn select_account_storage_map_values_paged(
.limit(i64::try_from(limit + 1).expect("limit fits within i64"))
.load(conn)?;

// Discard the last block in the response (assumes more than one block may be present)

// If we got more rows than the limit, the last block may be incomplete so we
// drop it entirely and derive last_block_included from the remaining rows.
let (last_block_included, values) = if let Some(&(last_block_num, ..)) = raw.last()
&& raw.len() > limit
{
// NOTE: If the query contains at least one more row than the amount of storage map updates
// allowed in a single block for an account, then the response is guaranteed to have at
// least two blocks

let values = raw
.into_iter()
.take_while(|(bn, ..)| *bn != last_block_num)
.map(StorageMapValue::from_raw_row)
.collect::<Result<Vec<_>, DatabaseError>>()?;

(BlockNumber::from_raw_sql(last_block_num.saturating_sub(1))?, values)
let last_block_included = values.last().map_or(*block_range.start(), |v| v.block_num);

(last_block_included, values)
} else {
(
*block_range.end(),
Expand Down
2 changes: 2 additions & 0 deletions crates/store/src/db/models/queries/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ pub fn select_transactions_records(
)?;

// SAFETY: block_num came from the database and was previously validated
// Subtraction is safe under the assumption that genesis block (where it could fail) does
// not have any transactions.
let last_included_block = BlockNumber::from_raw_sql(last_block_num.saturating_sub(1))?;
Ok((last_included_block, filtered_transactions))
} else {
Expand Down
Loading
Loading