Merged
Conversation
…pdate tests for chain-specific addresses. Added error handling for selector validation and improved test coverage for zkSync and Ethereum mainnet addresses.
…address references for Ethereum and zkSync chains.
…arding partial fills and nonce consumption.
… outdated test cases from Permit2Proxy tests.
SevenSwen
requested changes
Feb 12, 2026
Co-authored-by: Vasiliy Tikhonenko <tihonenko.v.v@gmail.com>
Co-authored-by: Vasiliy Tikhonenko <tihonenko.v.v@gmail.com>
SevenSwen
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Adds zkSync Era support to
Permit2Proxyby accepting a dynamic Permit2 contract address (EVM:0x000000000022D473030F116dDEE9F6B43aC78BA3, zkSync:0x0000000000225e31d15943971f47ad3022f714fa) and documents that the proxy must only be used with partial fills disabled due to single-use Permit2 nonces.Related Issue/Ticket
https://1inch.atlassian.net/browse/PT1-361
Changes
contracts/extensions/Permit2Proxy.sol— Constructor now accepts a_permit2address parameter instead of hardcoding it, enabling deployment on both EVM and zkSync chains.deploy/deploy-Permit2Proxy.js— New deployment script usingpermit2Address(chainId)from@uniswap/permit2-sdkfor chain-aware deployments via Create3.test/Permit2Proxy.js— Updated tests to pass both constructor arguments; added address verification tests for zkSync (chain 324) and Ethereum mainnet (chain 1).docs/extensions/Permit2Proxy.md— Updated constructor docs and added a note that partial fills are not supported.Testing & Verification
How was this tested?
Risk Assessment
Risk Level:
Risks & Impact