gnome: interpret {} as valid state with no windows focused#69
Merged
Conversation
Contributor
Author
|
For reference, the source of the empty JSON object: |
Owner
|
Thanks! I'll fix the warnings and roll out with another fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very basic fix for #50 where awatcher closes if no windows are focused in the first ~10 seconds of a Gnome + Wayland session. Accepting
{}as valid JSON data representing no focused windows is the workaround. Another equally simple alternative might be to make the fields on theWindowDatastruct optional.I've tested this locally and it works, but I'm no expert in this area so I can't comment on possible unintended side-effects.
I'm not a Rust developer so I wont take it personally if this PR is rejected, so long as the underlying issue is fixed. 🙏