Skip to content

Refactor/partsunit chaining #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Awsomeworld304 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor/partsunit chaining #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dddc145
Format partscandle.
Awsomeworld304 Feb 28, 2026
49da259
Make the to command in partsunits chainable.
Awsomeworld304 Feb 28, 2026
56624ab
Merge branch 'main' into refactor/partsunit-chaining
bduke-dev Mar 1, 2026
7d1d68f
Annotations to classpath.
Awsomeworld304 Mar 5, 2026
52da0f7
Merge remote-tracking branch 'origin/main' into refactor/partsunit-ch…
Awsomeworld304 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/org/parts3492/partslib/PARTsCandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ public PARTsCandle(String className, int canID, int ledLength, String canBusName
/*---------------------------------- Custom Private Functions ---------------------------------*/
protected void setColor(Color color) {
setControl(new EmptyAnimation(0));
setControl(new SolidColor(0, LED_LENGTH).withColor(new RGBWColor(color.r, color.g, color.b)));
setControl(
new SolidColor(0, LED_LENGTH).withColor(new RGBWColor(color.r, color.g, color.b)));
}

protected void setNoColor() {
Expand Down
13 changes: 7 additions & 6 deletions src/org/parts3492/partslib/PARTsUnit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,14 @@ public PARTsUnitType getUnitType() {
* @param unitType The target unit.
* @return Converted unit in double.
*/
public PARTsUnit toPARTsUnit(PARTsUnitType unitType) {
return new PARTsUnit(to(unitType), unitType);
}

/**
* Converts current unit into the requested unit.
*
* @param unitType The target unit.
* @return Converted unit in double.
*/
public double to(PARTsUnitType unitType) {
private double convertValue(PARTsUnitType unitType) {
String message = "No to type for unit.";
switch (this.unitType) {
case Angle:
Expand Down Expand Up @@ -171,15 +168,19 @@ public double to(PARTsUnitType unitType) {
}
}

public double getValueAsDouble() {
return this.value;
}

/**
* Converts current unit into the requested unit.
*
* @param unitType The target {@link org.parts3492.partslib.PARTsUnit.PARTsUnitType
* PARTsUnitType}.
* @return The converted {@link org.parts3492.partslib.PARTsUnit PARTsUnit}.
*/
public PARTsUnit as(PARTsUnitType unitType) {
return new PARTsUnit(to(unitType), unitType);
public PARTsUnit to(PARTsUnitType unitType) {
return new PARTsUnit(convertValue(unitType), unitType);
}

// * DIRECT STATIC CONVERSIONS */
Expand Down
Loading