-
Notifications
You must be signed in to change notification settings - Fork 113
Issue 6958 - Backport variable definition to fix test plan. #6959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 389-ds-base-3.0
Are you sure you want to change the base?
Conversation
…ness fails due to undefined variable. Description: The aforementioned test fails due to the variable MAIL_ATTR_VALUE_ALT being undefined. This takes the definition of MAIL_ATTR_VALUE_ALT from e61de56 and places it in attruniq_test.py. Resolves: 389ds#6958
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBackport the definition of MAIL_ATTR_VALUE_ALT into the attruniq_test suite to resolve an undefined variable in the test_multiple_attr_uniqueness test across multiple release branches. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbordaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test dirsrvtests/tests/suites/plugins/attruniq_test.py::test_multiple_attr_uniqueness fails on multiple branches due to the variable MAIL_ATTR_VALUE_ALT being undefined. This takes the definition of MAIL_ATTR_VALUE_ALT from e61de56 and places it in attruniq_test.py.
I've manually verified this fix on 389-ds-base-3.0, 2.7, 2.6, 2.5, 2.4, 2.3, 2.0, and 1.4.3.
Resolves: #6958
Summary by Sourcery
Tests: