Skip to content

Conversation

@abeisemb
Copy link
Collaborator

@abeisemb abeisemb commented Aug 29, 2025

The test dirsrvtests/tests/suites/plugins/attruniq_test.py::test_multiple_attr_uniqueness fails on multiple branches due to the variable MAIL_ATTR_VALUE_ALT being undefined. This takes the definition of MAIL_ATTR_VALUE_ALT from e61de56 and places it in attruniq_test.py.

I've manually verified this fix on 389-ds-base-3.0, 2.7, 2.6, 2.5, 2.4, 2.3, 2.0, and 1.4.3.

Resolves: #6958

Summary by Sourcery

Tests:

  • Define MAIL_ATTR_VALUE_ALT in attruniq_test.py to resolve test_multiple_attr_uniqueness failure

…ness fails due to undefined variable.

Description:
The aforementioned test fails due to the variable MAIL_ATTR_VALUE_ALT being undefined.
This takes the definition of MAIL_ATTR_VALUE_ALT from e61de56 and places it in attruniq_test.py.

Resolves: 389ds#6958
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backport the definition of MAIL_ATTR_VALUE_ALT into the attruniq_test suite to resolve an undefined variable in the test_multiple_attr_uniqueness test across multiple release branches.

File-Level Changes

Change Details Files
Add missing MAIL_ATTR_VALUE_ALT constant to test suite dirsrvtests/tests/suites/plugins/attruniq_test.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@abeisemb abeisemb requested a review from tbordaz August 29, 2025 18:25
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants