Skip to content

Conversation

@mreynolds389
Copy link
Contributor

@mreynolds389 mreynolds389 commented Jan 30, 2026

This is a test PR for checking flaky tests - DO NOT REVIEW

Summary by Sourcery

Adjust test behavior and logging to help diagnose and mitigate flakiness in replication and import tests.

Tests:

  • Add diagnostic output to replication wait-for-async feature test to log sync statistics during assertions.
  • Relax allowable difference between consecutive import times in regression test to reduce spurious timing-related failures.

@mreynolds389 mreynolds389 added the work in progress Work in Progress - can be reviewed, but not ready for merge. label Jan 30, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new print statements in wait_for_async_feature_test.py bypass the existing logging framework; consider switching these to log.debug (or similar) so they can be controlled via log levels and are less noisy in CI output.
  • The relaxed timing threshold in regression_test.py (< 20) is a magic number; consider extracting it into a named constant or adding a brief comment to explain why 20 seconds is appropriate for this test.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `print` statements in `wait_for_async_feature_test.py` bypass the existing logging framework; consider switching these to `log.debug` (or similar) so they can be controlled via log levels and are less noisy in CI output.
- The relaxed timing threshold in `regression_test.py` (`< 20`) is a magic number; consider extracting it into a named constant or adding a brief comment to explain why 20 seconds is appropriate for this test.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@progier389
Copy link
Contributor

Not sure that cockpit change should really belong to that PR about CI tests.
IMHO they deserve a separate PR

@mreynolds389
Copy link
Contributor Author

Not sure that cockpit change should really belong to that PR about CI tests. IMHO they deserve a separate PR

Don't worry it won't be in it - I was just doing it so it'd stop showing up in the results. Also this is not for review yet (see the description :-) ). I am just running tests in github to troubleshoot the tests that are commonly failing in the github env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Work in Progress - can be reviewed, but not ready for merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants