Issue 7076 - Fix revert_cache() never called in modrdn #7220
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: The postentry check in PR 389ds#7077 was broken - postentry is always NULL at that point, fixed by removing the check. Relates: 389ds#7076 Reviewed by: @vashirov
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider expanding the new comment above the
if (parent_op && betxn_callback_fails)block to briefly capture the previous nuance about only reverting when BETXN POST plugin callbacks fail (i.e., when cache modifications may have occurred), so future readers understand whybetxn_callback_failsis the right guard.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider expanding the new comment above the `if (parent_op && betxn_callback_fails)` block to briefly capture the previous nuance about only reverting when BETXN POST plugin callbacks fail (i.e., when cache modifications may have occurred), so future readers understand why `betxn_callback_fails` is the right guard.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mreynolds389
reviewed
Feb 3, 2026
| */ | ||
| if (parent_op && betxn_callback_fails && postentry) { | ||
| /* Revert the caches if this is the parent operation */ | ||
| if (parent_op && betxn_callback_fails) { |
Contributor
There was a problem hiding this comment.
This change makes me nervous because the comments specifically state that you only need to revert the cache if you hit the postop phase (where postentry is not NULL). Did you verify if a postop plugin fails that postentry is still NULL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The postentry check in PR #7077 was broken - postentry is always NULL at that point, fixed by removing the check.
Relates: #7076
Reviewed by: @vashirov
Summary by Sourcery
Bug Fixes: