RequestHandlerDelegate.contentTypes and RequestHandler.links#4
Open
rldhont wants to merge 2 commits into3liz:masterfrom
Open
RequestHandlerDelegate.contentTypes and RequestHandler.links#4rldhont wants to merge 2 commits into3liz:masterfrom
rldhont wants to merge 2 commits into3liz:masterfrom
Conversation
QgsServerOgcApiHandler::contentTypes not available in Python bindings Add RequestHandlerDelegate.contentTypes to return the list of content types this handler can serve, default to JSON and HTML.
QgsServerOgcApiHandler::links not available in Python bindings Add RequestHandler.links to get the self and alternate links for the given request
dmarteau
reviewed
Oct 18, 2021
Member
dmarteau
left a comment
dmarteau
left a comment
There was a problem hiding this comment.
Links depends It really depends on the structure of the API and I do net really understand the benefits of generating links this way
| super().__init__() | ||
| # Defined default content types because | ||
| # QgsServerOgcApiHandler::contentTypes not available in Python bindings | ||
| self._content_types = [QgsServerOgcApi.JSON, QgsServerOgcApi.HTML] |
Member
There was a problem hiding this comment.
There is no HTML files in the api so this is not apppropriate to pretend that there is HMTL links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide self and alternate links the
RequestHandlerDelegate.contentTypesandRequestHandler.linkshave been implemented becauseQgsServerOgcApiHandler::contentTypesandQgsServerOgcApiHandler::linksare not available in Python bindings.