Skip to content

Conversation

@JaminenB
Copy link

More information in issue:

CHANGES:

  • ADD: if-statement to check if ADD_MEMBER attribute is true and if the user is not a member of the organization
    • Uses the org.add_or_update_membership function to add the user to the organization
  • CHANGE: if-statement to add a user to a GitHub team only if they are a member of the organization already

More information in issue: 
- 3rd-party-integrations#214 

CHANGES:
- ADD: if-statement to check if ADD_MEMBER attribute is `true` and if the user is not a member of the organization 
  - Uses the org.add_or_update_membership function to add the user to the organization
- CHANGE: if-statement to add a user to a GitHub team only if they are a member of the organization already
@JaminenB JaminenB requested a review from primetheus as a code owner August 29, 2025 21:26
@JaminenB JaminenB marked this pull request as draft August 29, 2025 21:26
@JaminenB
Copy link
Author

Pending further testing. Changed to draft.

@JaminenB JaminenB marked this pull request as ready for review August 29, 2025 21:41
@JaminenB
Copy link
Author

JaminenB commented Aug 29, 2025

My testing shows that users are now being added to the organization as intended whereas before they were not being added even if the ADD_MEMBER attribute was set to true. This confirms what I was thinking in #214 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant