Implemented Event Card with placeholder images#38
Implemented Event Card with placeholder images#38VasilakiG wants to merge 6 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
languages logos can be part of the database
There was a problem hiding this comment.
Yes, but let's include that in a follow-up PR since the database is not ready yet for such things.
| display: "flex", | ||
| alignItems: "flex-end", | ||
| justifyContent: "flex-end", | ||
| width: "5%", |
There was a problem hiding this comment.
Remove all percentages from everywhere.
There was a problem hiding this comment.
Removed and replaced them with values following the given theme.
| height: "100%", | ||
| justifyContent: "center", | ||
| alignContent: "center", | ||
| padding: "1%", |
There was a problem hiding this comment.
Never use percentages for spacing, it's very unpredictable:
There was a problem hiding this comment.
Followed the guide and replaced all the percentages.
| borderRadius: "10px", | ||
| margin: "auto", | ||
| marginTop: "5%", | ||
| boxShadow: "0px 0px 1.5px 0px #fff", |
There was a problem hiding this comment.
There was a problem hiding this comment.
Made a custom boxShadow inside the theme, under shadows[].
vergjor
left a comment
vergjor
left a comment
There was a problem hiding this comment.
also the padding of the elements within the card should be aligned better, compare with the figma design for reference
Co-authored-by: Veronika Gjoreva <86774177+vergjor@users.noreply.github.com>
VasilakiG
force-pushed
the
COLOS-6-setup-event-card
branch
from
e48b5b4 to
7a707fe
Compare
…troduced constants for full width and full height
…he title of the competition not wrappable and show dots when overflowed, updated values of elements, so they look closer to the proposed design
Aligned them to look similar to the Figma design. |
|
Closed the PR because of a small miss-click, wanting to remove an unwanted comment... |
…pear in the card, no more shift of elements
3 participants
Issue ID
COLOS-6
What has been done?
Sceenshots/Videos