Fix styling, css baseline, spacing #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vergjor
reviewed
May 28, 2024
Comment on lines
-32
to
-34
| marginLeft: 2, | ||
| paddingTop: 2, | ||
| paddingBottom: 2, |
Contributor
There was a problem hiding this comment.
the paddings need to be re-added since they are needed for the code editor to have rounded corners and for the code to not be that close to the editor borders, as in the design (excluding the marginLeft). marginLeft can be moved to the parent component (Paper) so that both the "Select a language" label and the editor can be aligned
vergjor
requested changes
May 28, 2024
Contributor
vergjor
left a comment
vergjor
left a comment
There was a problem hiding this comment.
small comment in CodeEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ID
What has been done?
Sceenshots/Videos
Screen.Recording.2024-04-02.at.22.51.40.mov