Resolve redundancy of add_other functions #1641
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, the
add_other()methods are deleted fromSparseOperatorand its sub-classes. In the current implementation, these methods where used to call the overloaded add() functions from theSparseOperatorfor the sub-classesSparseMatrixandBlockSparseMatrixBase, which results in confusing code. I think this is done to be sure that only aSparseMatrixis added to aSparseMatrixinstance and aBlockSparseMatrixBaseadded to aBlockSparseMatrixBaseinstance.In this PR, a
dynamic_castis added to be sure that the correct matrix types are added.Related Issues and Pull Requests
Related to #136