Remove cardiovascular0d from old time integration framework #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request removes cardiovascular0d functionality from the old time integration framework after migrating all tests to the new framework. The changes delete unused code and consolidate test files.
Key Changes:
- Removed cardiovascular0d-specific test files with "_new_struc" suffix from test list
- Added
INT_STRATEGY: "Standard"configuration to remaining cardiovascular0d test files - Deleted cardiovascular0d integration code from old structure time integration classes
- Removed cardiovascular0d manager integration from structure time integrators
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/list_of_tests.cmake | Removed "_new_struc" test variants, consolidated to single test per scenario, moved "minimal" label |
| tests/input_files/*.4C.yaml | Updated test configurations with INT_STRATEGY, removed "_new_struc" files |
| src/structure/4C_structure_timint_*.cpp | Removed cardiovascular0d force/stiffness evaluation and update calls |
| src/structure/4C_structure_timint_impl.cpp/hpp | Removed cardiovascular0d manager integration and related methods |
| src/cardiovascular0d/*.hpp | Removed cardiovascular0d manager methods for old framework integration |
| src/adapter/*.hpp | Removed cardiovascular0d update methods from adapter interfaces |
| src/inpar/4C_inpar_structure.* | Removed divcont_adapt_3D0Dptc_ele_err enum value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amgebauer
force-pushed
the
move-cardiovascular-tests-to-new-solid-timeintegration
branch
from
d78057f to
511eef8
Compare
maxfirmbach
approved these changes
Jan 9, 2026
Contributor
maxfirmbach
left a comment
maxfirmbach
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up 👍.
tuchpaul
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All existing tests in the old time integration framework have been migrated to the new time integration framework. The now unused code parts are deleted.