Migrate GroupEvent from Material UI TextField to native HTML input#8276
Draft
Migrate GroupEvent from Material UI TextField to native HTML input#8276
Conversation
This change improves performance and simplifies the GroupEvent component by replacing the Material UI TextField with a native HTML input element. Changes: - Replace TextField with native <input> element - Update event handling to use native onChange and onKeyDown - Adjust CSS styling to ensure proper alignment between edit and display modes - Update Material UI input CSS rules for better consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the GroupEvent component by replacing the Material UI TextField with a native HTML input element, mainly to avoid the visual offset when in edit mode compared to the display mode.
This native input approach is inspired from the CommentEvent that is working perfectly.
Changes:
I did a review with this prompt based on previous reviews: