Open
Conversation
mamo3gr
reviewed
Mar 5, 2026
| # Step 2 | ||
| 過去のレビューを見て修正([Code4](#Code4))： | ||
| - 単なる数字（例えば`1`や`0`）が意味を持つ場合は，定数で置いて意味をわかりやすくする． | ||
| - [Style Guide](https://ttsuki.github.io/styleguide/cppguide.ja.html#:~:text=てください%E3%80%82-,定数,-名)に従い`kObstacle`としたが，この変数名はわかりやすいのか？大文字で`OBSTACLE`のようにした方がわかりやすい気もする．ご意見・採用しているプラクティスなどあればお待ちしております． |
There was a problem hiding this comment.
一貫性があれば kObstacle でも OBSTACLE でも、可読性は大差ないと感じました。
mamo3gr
reviewed
Mar 5, 2026
Comment on lines
+109
to
+110
| int m = obstacleGrid.size(); | ||
| int n = obstacleGrid[0].size(); |
There was a problem hiding this comment.
インデックスに合わせて、ここも num_rows とか num_columns にしたほうが分かりやすそうです。
mamo3gr
reviewed
Mar 5, 2026
Comment on lines
+119
to
+122
| if (obstacleGrid[row - 1][col - 1] == kObstacle) { | ||
| continue; | ||
| } | ||
| num_paths[row][col] += num_paths[row - 1][col] + num_paths[row][col - 1]; |
There was a problem hiding this comment.
ひとつ余分に取っておくと、obstacleGrid を -1 で引く必要があるっぽうで、境界での分岐をしなくて良くなるんですね。
Owner
Author
There was a problem hiding this comment.
そうですね．
今回の問題やprefix sumなど漸化式的に表現できるときは，一つ余分に取ることでエッジケースを取り込めることがしばしばあって便利です．
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
63. Unique Paths II