Open
Conversation
Collaborator
|
Thank you for opening the PR - I will have to take some time to look over this but currently I am quite busy, so I am not sure yet when I will find the time |
Collaborator
|
Thank you for the PR - I would love to have a quick chat with you about it. You can reach me via florian@8080labs.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add paralleling compurations for pps.matrix. In my sample test data with 20 columns on 8CPU machine boost from 21 second to 5.7.
But for data with a lot of columns(>60) still too slow. I have idea to add parameter for selection only interesting columns from data(maybe interesting for specific column) and optimize calculations for data with a large number of columns. Also it will be usefull for better matrix understanding.