Skip to content

Model pipelining support#50

Open
HectorBarrio wants to merge 8 commits into8080labs:devfrom
HectorBarrio:Model-pipelining-support
Open

Model pipelining support#50
HectorBarrio wants to merge 8 commits into8080labs:devfrom
HectorBarrio:Model-pipelining-support

Conversation

@HectorBarrio
Copy link

Hello, pulling into "dev" branch, I hope this is the intended branch.

barrioh and others added 7 commits January 8, 2021 19:11
Remove auto formatting changes.
Remove formatting change clutter.
Reduce change clutter.
Improve explanation.
@FlorianWetschoreck
Copy link
Collaborator

Thank you! I will review this in the following days :)

@FlorianWetschoreck
Copy link
Collaborator

Thank you for providing the PR.

Can you please create a sample notebook which shows and explains the usage of the new API?
The focus is on showing in which exact scenario you would use the new API and how it is useful compared to an alternative solution

Pipeline usage example.
@HectorBarrio
Copy link
Author

@FlorianWetschoreck
Copy link
Collaborator

Thank you for providing this - the github.com link worked - datalore did not.
I will think about this in the following days :)

@FlorianWetschoreck
Copy link
Collaborator

Hey Hector, thank you for providing the demo notebook.
That was very important for the actual decision because we needed to see the full thing in a live context.

Currently, we want to keep the package short and sweet without integrating pipeline support at this time.
This might change if there are other good examples and more demand. Also, people can use the code from your github repo in the meantime if they really want to

Also, feel free to create a separate repo where you add more features on top of the base ppscore package e.g. including the multiprocessing support that was proposed in another branch

@HectorBarrio
Copy link
Author

Ok Florian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants