Adding new flag for optional calculation of Volumes created at the root#1390
Open
vmattphillips wants to merge 1 commit into9001:hovudstraumfrom
Open
Adding new flag for optional calculation of Volumes created at the root#1390vmattphillips wants to merge 1 commit into9001:hovudstraumfrom
vmattphillips wants to merge 1 commit into9001:hovudstraumfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this as a potential fix for #1033
The block of code I changed in httpcli should now query into the volumes at the root and fetch their sizes, this shouldn't effect anything else, as its blocked behind an optional flag for "deep" searching the directory sizes. (deep-dirsz)
before it would pass over since the database excludes the config defined volumes from indexing, this just adds an extra check if the result was falsey / none, AND if the user actually wants to see the sizes
(I've never made a pr to a repo that wasn't just me and my friends / classmates in college sorry if something is wrong)
This PR complies with the DCO; https://developercertificate.org/