Skip to content

Refactored code. Added .gitignore file#1

Open
93mike wants to merge 3 commits intomainfrom
refactoring
Open

Refactored code. Added .gitignore file#1
93mike wants to merge 3 commits intomainfrom
refactoring

Conversation

@93mike
Copy link
Owner

@93mike 93mike commented Mar 23, 2023

Just cleaning up

@@ -57,7 +56,6 @@ public static void findLongestWordInFile() throws FileNotFoundException {
Scanner scanner = new Scanner(new File("C:\\Users\\mmazu2\\studying\\text.txt"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is should be a relative path to the text file. E.g. start with 'System.getProperty("user.dir")' and then put a file destination in the framework

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the file is empty (with no test data). Also, it would be better not to store it in the root of the project but in 'resources' folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants