Catch keychain's errSecUserCanceled #119
Open
JulianToledano wants to merge 1 commit into99designs:masterfrom
Open
Catch keychain's errSecUserCanceled #119JulianToledano wants to merge 1 commit into99designs:masterfrom
JulianToledano wants to merge 1 commit into99designs:masterfrom
Conversation
* Update gitignore * Add ErrAccessDenied error * Add error description on errSecUserCanceled * Run CI on pull requests
|
@mtibben any chance we can get this merged, it would allow us to unfork this repository |
12 tasks
|
@mtibben @tac0turtle any chances of merging this? |
25 tasks
4 tasks
|
Maintained fork: https://github.com/ByteNess/keyring/ Contributions are welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a bug while making use of this package on the cosmos-sdk. If a user denies to enter the password in the prompt while using keychain, a misleading error is returned (more info in the issue). This is because
errSecUserCanceledis not being catch. This PR catch that error and return an expected error