Skip to content

Conversation

@Francisco-G-P
Copy link

While the main task was to eliminate some deprecated comments, some more were added in specific areas where a brief explanation was needed. Most of the deleted comments were print statements for what seem where early tests.

At the same time, comments that were added or restructured were done following best practices. In main.py the start variable was moved away from the imports and in text_to_img.py from PIL import Image was deleted as its use was commented out (that comment was deleted as well).

@Francisco-G-P
Copy link
Author

Hi, @ABarpanda I've submitted the reviewed version of the Animegen files! Please let me know if there are changes to be made.

Copy link
Owner

@ABarpanda ABarpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of start = timeit.default_timer() in main.py was intentional.
When we import scene_split, some part of the program is run, which delays the execution of main.py. Since that is also included in the time we have to wait for the program to run, start must be placed before imports.

@Francisco-G-P
Copy link
Author

I understand, sorry for the inconvenience. I've applied the necessary change to main.py.

@Francisco-G-P Francisco-G-P requested a review from ABarpanda March 12, 2025 16:10
Copy link
Owner

@ABarpanda ABarpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Francisco-G-P , the import slideshow was also intentionally placed at the end.
Please refer to #3 for more detail.

@Francisco-G-P
Copy link
Author

After reviewing Issue #3 I got why it was placed at the end of the file, thanks! I've applied the necessary change to main.py.

@Francisco-G-P Francisco-G-P requested a review from ABarpanda March 12, 2025 16:45
@Francisco-G-P
Copy link
Author

Hi! @ABarpanda I've applied the last two changes to the Animegen files! Please let me know if there are any more changes needed to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants