-
Notifications
You must be signed in to change notification settings - Fork 5
Corrected deprecated comments and followed best practices #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, @ABarpanda I've submitted the reviewed version of the Animegen files! Please let me know if there are changes to be made. |
ABarpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placement of start = timeit.default_timer() in main.py was intentional.
When we import scene_split, some part of the program is run, which delays the execution of main.py. Since that is also included in the time we have to wait for the program to run, start must be placed before imports.
|
I understand, sorry for the inconvenience. I've applied the necessary change to main.py. |
ABarpanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Francisco-G-P , the import slideshow was also intentionally placed at the end.
Please refer to #3 for more detail.
|
After reviewing Issue #3 I got why it was placed at the end of the file, thanks! I've applied the necessary change to main.py. |
|
Hi! @ABarpanda I've applied the last two changes to the Animegen files! Please let me know if there are any more changes needed to be made. |
While the main task was to eliminate some deprecated comments, some more were added in specific areas where a brief explanation was needed. Most of the deleted comments were
printstatements for what seem where early tests.At the same time, comments that were added or restructured were done following best practices. In main.py the
startvariable was moved away from the imports and in text_to_img.pyfrom PIL import Imagewas deleted as its use was commented out (that comment was deleted as well).