Skip to content

Disable AWS X-Ray in resource-api until it's needed. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable AWS X-Ray in resource-api until it's needed. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion resource-api/infra/helm-v2/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ spec:
- name: DYNAMODB_TABLE
value: {{ .Release.Namespace }}-resources
- name: AWS_DEFAULT_REGION
value: {{ .Values.aws.region}}
value: {{ .Values.aws.region }}
- name: AWS_XRAY_SDK_ENABLED
value: "{{ .Values.aws.xray_enabled }}"
resources:
{{ toYaml .Values.resources | indent 12 }}
{{- with .Values.nodeSelector }}
Expand Down
1 change: 1 addition & 0 deletions resource-api/infra/helm-v2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ service:

aws:
region: us-east-2
xray_enabled: "false"

resources: {}
# limits:
Expand Down
4 changes: 3 additions & 1 deletion resource-api/infra/helm-v3/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ spec:
- name: DYNAMODB_TABLE
value: {{ .Release.Namespace }}-resources
- name: AWS_DEFAULT_REGION
value: {{ .Values.aws.region}}
value: {{ .Values.aws.region }}
- name: AWS_XRAY_SDK_ENABLED
value: "{{ .Values.aws.xray_enabled }}"
resources:
{{ toYaml .Values.resources | indent 12 }}
{{- with .Values.nodeSelector }}
Expand Down
5 changes: 4 additions & 1 deletion resource-api/infra/helm-v3/values.development.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
image:
repository: 750796802028.dkr.ecr.us-east-2.amazonaws.com/bookstore.resources-api
tag: latest
tag: latest

aws:
xray_enabled: "true"
5 changes: 4 additions & 1 deletion resource-api/infra/helm-v3/values.prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
image:
repository: 750796802028.dkr.ecr.us-east-2.amazonaws.com/bookstore.resources-api
tag: latest
tag: latest

aws:
xray_enabled: "false"
4 changes: 3 additions & 1 deletion resource-api/infra/helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ spec:
- name: DYNAMODB_TABLE
value: {{ .Release.Namespace }}-resources
- name: AWS_DEFAULT_REGION
value: {{ .Values.aws.region}}
value: {{ .Values.aws.region }}
- name: AWS_XRAY_SDK_ENABLED
value: "{{ .Values.aws.xray_enabled }}"
resources:
{{ toYaml .Values.resources | indent 12 }}
{{- with .Values.nodeSelector }}
Expand Down
1 change: 1 addition & 0 deletions resource-api/infra/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ service:

aws:
region: us-east-2
xray_enabled: "false"

resources: {}
# limits:
Expand Down