Interface improvements for python classes (analyzers and planners)#18
Open
arthursloan wants to merge 4 commits intoDevelopfrom
Open
Interface improvements for python classes (analyzers and planners)#18arthursloan wants to merge 4 commits intoDevelopfrom
arthursloan wants to merge 4 commits intoDevelopfrom
Conversation
…roperty definitions for convenice when working with planner. Added the ability to intialize a plan response with a dictionary rather than lists of keys and values.
…t like that unless you're on v3.12+)
Member
|
@arthursloan I've made a few changes to your pull request as they were failing some tests. Prior to Python 3.12 there isn't support for using backslashes in format strings (f strings), which caused some testing failures on the pipeline. With those changes in place the test are passing and this pull request looks good to me. If you could confirm your outputs are still as you expect them I'll merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added str and repr functions to analyzer and planner classes for easier interactive debugging when working on developing planners and analyzers. Also added some helper functionality to make it easier to access the data within plan request objects.