Update WP naming convention #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
approved these changes
Oct 29, 2025
jamOne-
approved these changes
Oct 29, 2025
|
look much simpler and gracefully fix the problem! |
SikaGrr
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Update WP naming convention * Fix goldens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the WP naming convention so that for clusters using the same device type and the same topology, the WP is reused. This will also break the 1-1 association of WP to cluster names, which caused the issue described below and will also help reduce the total number of WPs on the project.
Issue
#752
Testing
Manual testing was performed