feat: Make Kueue installation required to consider cluster creation successful #763
+44
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
approved these changes
Oct 30, 2025
FIoannides
approved these changes
Oct 30, 2025
SikaGrr
approved these changes
Oct 30, 2025
|
@SikaGrr it's hard because I'd have to mock so many dependencies. Although it's possible to test the |
|
Added the small |
SikaGrr
pushed a commit
that referenced
this pull request
Oct 30, 2025
…uccessful (#763) * feat: Make Kueue installation required to consider cluster creation successful * style: Make install_kueue private * Add kueue_installation code unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, even though Kueue installation failed, the user could see the successful exit of XPK at the end.
Also style change for the
kubectl waitcommand.-nkueue-systemalso worked, but the space makes it more clear.Issue
Testing