Support Wrangler authentication in setup script#51
Conversation
- Add check for existing Wrangler authentication using `wrangler whoami`. - Extract Cloudflare Account ID from Wrangler output if authenticated. - Skip Cloudflare credential prompts if Wrangler is authenticated. - Update flag validation to allow missing Cloudflare credentials if authenticated. - Update `.env` generation to conditionally include Cloudflare credentials. - Change fallback installation to local `npm install` instead of global `npm install -g wrangler`. Co-authored-by: AJFrio <20246916+AJFrio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Line 120 in af74843
Keep detected account ID when flags omit account value
After wrangler whoami populates cloudflareAccountId, flag mode unconditionally overwrites it with args.cloudflare_account_id, which is often undefined. In runs where the user is authenticated and provides --cloudflare-api-token but omits --cloudflare-account-id, the script then enters API-token auth with no account ID set, so downstream wrangler commands can lose account context and fail. Preserve the detected ID as a fallback (or require token+account-id as an all-or-nothing pair).
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Updated
scripts/setup.jsto detect if the user is already authenticated with Wrangler. If so, it skips the prompt for Cloudflare API Token and Account ID, and attempts to extract the Account ID fromwrangler whoamioutput. It also updates the.envfile generation to only include Cloudflare credentials if they were explicitly provided. Additionally, changed the fallback installation command tonpm installfor better project hygiene.PR created automatically by Jules for task 16971097749800352353 started by @AJFrio