Conversation
Pre-computes maps of existing variant IDs to avoid O(N) finds within the incoming variants mapping loop, reducing overall complexity from O(N^2) to O(N). Includes new benchmark proving a roughly 10x speedup (3210ms to 289ms) with 15k variants. Co-authored-by: AJFrio <20246916+AJFrio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced the inefficient
.find()array traversals inupdateProductVariantswith an initialMapconstruction forO(1)lookups. This applies to both thevariantsandvariants2processing loops.🎯 Why: The previous code had
O(N^2)time complexity because it calledArray.prototype.find()inside ofArray.prototype.map(). This caused significant performance degradation when processing updates for products with many variants.📊 Measured Improvement: Created a dedicated performance test (
tests/services/ProductStripeService.perf.test.js) testing an update containing 15,000 variants.PR created automatically by Jules for task 5050931632602237222 started by @AJFrio