Skip to content

⚡ Optimize O(N^2) array traversal for variant updates in ProductStripeService#60

Merged
AJFrio merged 1 commit intomainfrom
perf-optimize-variant-updates-5050931632602237222
Mar 6, 2026
Merged

⚡ Optimize O(N^2) array traversal for variant updates in ProductStripeService#60
AJFrio merged 1 commit intomainfrom
perf-optimize-variant-updates-5050931632602237222

Conversation

@AJFrio
Copy link
Copy Markdown
Owner

@AJFrio AJFrio commented Mar 6, 2026

💡 What: Replaced the inefficient .find() array traversals in updateProductVariants with an initial Map construction for O(1) lookups. This applies to both the variants and variants2 processing loops.
🎯 Why: The previous code had O(N^2) time complexity because it called Array.prototype.find() inside of Array.prototype.map(). This caused significant performance degradation when processing updates for products with many variants.
📊 Measured Improvement: Created a dedicated performance test (tests/services/ProductStripeService.perf.test.js) testing an update containing 15,000 variants.

  • Baseline (Before): ~3210 ms
  • Improvement (After): ~289 ms
  • Change: ~11x faster (+91% improvement)

PR created automatically by Jules for task 5050931632602237222 started by @AJFrio

Pre-computes maps of existing variant IDs to avoid O(N) finds within
the incoming variants mapping loop, reducing overall complexity from
O(N^2) to O(N). Includes new benchmark proving a roughly 10x speedup
(3210ms to 289ms) with 15k variants.

Co-authored-by: AJFrio <20246916+AJFrio@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@AJFrio AJFrio merged commit 7101d7f into main Mar 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant