-
Notifications
You must be signed in to change notification settings - Fork 1
β‘ Optimize collection products grouping in Navbar #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AJFrio
merged 1 commit into
main
from
performance/navbar-collection-products-lookup-1352758579920581065
Mar 6, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { performance } from 'perf_hooks'; | ||
|
|
||
| // Setup mock data | ||
| const NUM_COLLECTIONS = 100; | ||
| const NUM_PRODUCTS = 5000; | ||
|
|
||
| const collectionsData = Array.from({ length: NUM_COLLECTIONS }, (_, i) => ({ | ||
| id: `collection_${i}`, | ||
| name: `Collection ${i}` | ||
| })); | ||
|
|
||
| const productsData = Array.from({ length: NUM_PRODUCTS }, (_, i) => ({ | ||
| id: `product_${i}`, | ||
| collectionId: `collection_${Math.floor(Math.random() * NUM_COLLECTIONS)}`, | ||
| name: `Product ${i}` | ||
| })); | ||
|
|
||
| function baseline() { | ||
| const start = performance.now(); | ||
| const collectionsWithProducts = collectionsData.map(collection => ({ | ||
| ...collection, | ||
| products: productsData.filter(product => product.collectionId === collection.id) | ||
| })); | ||
| return performance.now() - start; | ||
| } | ||
|
|
||
| function optimized() { | ||
| const start = performance.now(); | ||
| const productsByCollectionId = productsData.reduce((acc, product) => { | ||
| if (!acc[product.collectionId]) { | ||
| acc[product.collectionId] = []; | ||
| } | ||
| acc[product.collectionId].push(product); | ||
| return acc; | ||
| }, {}); | ||
|
|
||
| const collectionsWithProducts = collectionsData.map(collection => ({ | ||
| ...collection, | ||
| products: productsByCollectionId[collection.id] || [] | ||
| })); | ||
| return performance.now() - start; | ||
| } | ||
|
|
||
| const iterations = 100; | ||
| let baselineTotal = 0; | ||
| let optimizedTotal = 0; | ||
|
|
||
| // Warmup | ||
| for (let i=0; i<10; i++) { | ||
| baseline(); | ||
| optimized(); | ||
| } | ||
|
|
||
| for (let i = 0; i < iterations; i++) { | ||
| baselineTotal += baseline(); | ||
| optimizedTotal += optimized(); | ||
| } | ||
|
|
||
| console.log(`Baseline Avg: ${(baselineTotal / iterations).toFixed(2)} ms`); | ||
| console.log(`Optimized Avg: ${(optimizedTotal / iterations).toFixed(2)} ms`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new grouping logic stores products in a plain object keyed by
product.collectionId, but IDs come from API data and can collide with inherited keys likeconstructorortoString. In those casesif (!acc[id])incorrectly treats the inherited function as an existing bucket andacc[id].push(...)throws, which breaks navbar rendering for affected stores; the previousfilter-based version did not have this failure mode. UseObject.create(null)or aMap(or at leastObject.hasOwn) for bucket lookups.Useful? React with πΒ / π.