-
Notifications
You must be signed in to change notification settings - Fork 6
amd-ras: Modify to call apml alert APIs to monitor RAS alerts #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akky16
wants to merge
2
commits into
integ_sp7
Choose a base branch
from
ras-app-alertl-integ_sp7
base: integ_sp7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@akky16 Is this verified on 2P systems by injecting error on P1 socket? |
ojayanth
suggested changes
Jun 17, 2025
aabb8b8 to
f238690
Compare
ojayanth
reviewed
Jun 19, 2025
f238690 to
e23abaf
Compare
Collaborator
e23abaf to
c38e16b
Compare
- Modify configure() to call APML API:
The configure() function is modified to replace userspace
gpiolib with the APML API "apml_register_udev_monitor()" which
registers for uevents from the Alert_L driver associated with RAS events.
- Create alertSrcHandler() to monitor RAS alerts:
The alertSrcHandler() function calls the APML API
"monitor_ras_alert()" to monitor RAS alert from the Alert_L driver.
A single instance of alertSrcHandler() can handle alerts from
multiple sockets. Monitoring the Alert_L GPIO and clearing
the RMI Status(0x2) and RMI RASstatus(0x4c) registers on RAS alert
is managed by the APML driver.
These change do not alter the overall structure and CPER creation.
Requesting, Binding and monitoring of GPIOs can be removed as this
functionality is now handled by the Alert_L driver. Only one thread
is required to monitor RAS alerts, regardless of the number of
sockets.
This implementation allows multiple user applications to register
for uevents and get the alert source information simultaneously.
Tested fields - Verified on Morocco system (P0 and P1).
CPER files are generated upon FATAL error injection for the socket.
Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Signed-off-by: Sathya Priya Kumar <SathyaPriya.K@amd.com>
Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>
Support receiving interrupt for MCA Shutdown events On a MCA shutdown error , ALERT_L will be triggered. Alert_L module checks the RasStatusReg[Bit6] to identify shutdown event and sends the event to user space. Upon receiving the event, Ras app follows ths fatal error path to harvest MCA banks and create CPER record and take recovery action. Tested fields: Unit test done for shutdown error in Congo. Signed-off-by: Sathya Priya Kumar <SathyaPriya.K@amd.com> Signed-off-by: Akshay Gupta <akshay.gupta@amd.com> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
c38e16b to
597c735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Update apml_manager to call APML APIs to register for uevent from apml alertl driver.