Check boot mode to validate parameter HostNumber #48
+72
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify boot mode of the system using an existing dbus service. Boot mode for Single Node [2P-Default] is 0 and it is 1 for Multi-Node [2x1P]. Check the URL for resource bios_active and parameter HostNumber. If the boot mode is Multi-Node [2x1P] and HostNumber is 0, return an error. 0 is not a valid parameter HostNumber value for the resource bios_active on Multi-Node [2x1P] systems. Tested: Verified on Multi-Node [2x1P] and Single Node [2P-Default] systems. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
Collaborator
Author
|
#45 for integ_sp8 ../../../../../../workspace/sources/bmcweb/meson.build:1:0: ERROR: Unknown options: "mutual-tls-common-name-parsing" |
Collaborator
Author
Able to figure out, no more error. So this code is good for review (and it is the same exact code for the one for integ_sp7). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify boot mode of the system using an existing dbus service. Boot mode for Single Node [2P-Default] is 0 and it is 1 for Multi-Node [2x1P].
Check the URL for resource bios_active and parameter HostNumber. If the boot mode is Multi-Node [2x1P] and HostNumber is 0, return an error.
0 is not a valid parameter HostNumber value for the resource bios_active on Multi-Node [2x1P] systems.
Tested:
Verified on Multi-Node [2x1P] and Single Node [2P-Default] systems.