changes in smart contract there is a critical bug which can lead to manipulation of election result + Gas optimization

[hoBabu1]

Added a new file - findings.md . Must have a look at it

Description

I have made some of the common and necessary changes that are needed for the contract, when it goes for audit in future.
Please have a look in a file - findings.md I have listed down all things in details for the changes that i have done. As well i have recommended some changes that would be really helpful for this project please go through all that, I haven't made that changes that would result in change in a bit architecture of the project, Once the core team confirms i will do the changes. There was no proper documentation for contracts, it was difficult to understand the role of functions.

More things needed to be done

• Using foundry setup instead of hardhat. It is faster and industry friendly
• Writing unit test and fuzz test
• Making code coverage above 95%
• Gas optimization - Using mapping over array.
• Making it more gas optimized by refactoring the code base

Type of change

Please mark the options that are relevant.

• Updated UI/UX
• Improved the business logic of code
• Added new feature
• [ ✅ ] Other

Checklist:

• [ ✅ ] I have performed a self-review of my own code
• [ ✅ ] I have commented my code, particularly in hard-to-understand areas
• [ ✅ ] I have made corresponding changes to the documentation
• [✅ ] My changes generate no new warnings