feat: add mark as taken functionality for medicine tracker (#44) #115
Conversation
WalkthroughA new feature is added to mark medicines as taken or not taken. The backend introduces a PATCH endpoint at Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
Backend/routes/medicine.py (1)
163-163: Validate thetakenfield type for robustness.The
taken_statusis extracted without type validation. While the frontend sends a boolean, a malformed request could pass a non-boolean value (e.g., string, number, null), which SQLite might coerce unexpectedly.Apply this diff to add type validation:
- taken_status = data.get('taken', True) # Default to True if not specified + taken_status = data.get('taken', True) + if not isinstance(taken_status, bool): + return jsonify({"error": "Taken status must be a boolean"}), 400Frontend/src/Screens/MedicineScreen.jsx (2)
129-141: Add response validation and consider optimistic updates.The function doesn't validate the response status before refreshing. If the backend returns an error (e.g., 404, 500), the history is still refreshed, potentially showing stale data.
Apply this diff to validate the response:
const handleMarkAsTaken = async (id, currentStatus) => { try { - await fetch(`${BASE_URL}/medicine/${id}/taken`, { + const response = await fetch(`${BASE_URL}/medicine/${id}/taken`, { method: 'PATCH', headers: {'Content-Type': 'application/json'}, body: JSON.stringify({taken: !currentStatus}), }); + if (!response.ok) { + throw new Error(`Server responded with ${response.status}`); + } fetchMedicineHistory(); } catch (err) { console.error('Failed to mark medicine:', err); Alert.alert('Error', 'Failed to update medicine status.'); } };Alternatively, consider implementing optimistic updates to improve perceived responsiveness.
216-222: Consider debouncing to prevent race conditions.Rapid clicks on the icon could trigger multiple concurrent PATCH requests, leading to inconsistent state or unexpected toggle behavior.
Add a loading state or debounce the handler:
const [updatingMedicine, setUpdatingMedicine] = useState(null); const handleMarkAsTaken = async (id, currentStatus) => { if (updatingMedicine === id) return; // Prevent concurrent updates setUpdatingMedicine(id); try { const response = await fetch(`${BASE_URL}/medicine/${id}/taken`, { method: 'PATCH', headers: {'Content-Type': 'application/json'}, body: JSON.stringify({taken: !currentStatus}), }); if (!response.ok) { throw new Error(`Server responded with ${response.status}`); } fetchMedicineHistory(); } catch (err) { console.error('Failed to mark medicine:', err); Alert.alert('Error', 'Failed to update medicine status.'); } finally { setUpdatingMedicine(null); } };Conditionally disable the icon while updating:
<TouchableOpacity onPress={() => handleMarkAsTaken(entry.id, entry.taken)} disabled={updatingMedicine === entry.id}> <Icon name={entry.taken ? 'check-circle' : 'radio-button-unchecked'} size={24} color={updatingMedicine === entry.id ? '#bdc3c7' : (entry.taken ? '#27ae60' : '#95a5a6')} style={styles.checkIcon} /> </TouchableOpacity>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Backend/routes/medicine.py(1 hunks)Frontend/src/Screens/MedicineScreen.jsx(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
Backend/routes/medicine.py (3)
Backend/db/db.py (1)
open_db(8-13)Backend/agent/agent.py (2)
get_agent(97-102)update_cache(63-72)Backend/agent/cache.py (1)
update_cache(270-364)
🔇 Additional comments (3)
Frontend/src/Screens/MedicineScreen.jsx (2)
372-378: LGTM!The styling for taken entries is clear and appropriate. The line-through decoration and muted color effectively communicate the taken state.
216-222: > Likely an incorrect or invalid review comment.Backend/routes/medicine.py (1)
152-174: The database schema correctly includes thetakencolumn.The
weekly_medicinetable inBackend/schema.sqldefinestakenas aBOOLEANcolumn with a default value of 0, confirming the endpoint implementation is properly supported by the schema.
1 participant
Closes #
📝 Description
🔧 Changes Made
📷 Screenshots or Visual Changes (if applicable)
🤝 Collaboration
Collaborated with:
@username(optional)✅ Checklist
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.