-
Notifications
You must be signed in to change notification settings - Fork 107
Fix for issue #135 DOCS UPDATE: Commands supposed to run separately m… #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for issue #135 DOCS UPDATE: Commands supposed to run separately m… #144
Conversation
…parately mixed together in one block AOSSIE-Org#135 modified: Backend/.gitignore modified: Backend/db/chromadb/chroma.sqlite3 modified: Frontend/.gitignore modified: Frontend/android/gradlew modified: Frontend/ios/BabyNest/PrivacyInfo.xcprivacy modified: Frontend/ios/Podfile.lock modified: Setup.md
📝 WalkthroughWalkthroughThis PR updates documentation to separate concurrent terminal commands into distinct workflows for Android and iOS setup, adds ChromaDB artifacts to backend gitignore, updates frontend gitignore with platform-specific entries, and modifies iOS privacy API declarations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed Android gradlew files and iOS Podfile.lock from .gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Frontend/ios/Podfile.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
Backend/.gitignoreBackend/db/chromadb/chroma.sqlite3Frontend/.gitignoreFrontend/android/gradlewFrontend/ios/BabyNest/PrivacyInfo.xcprivacySetup.md
🔇 Additional comments (4)
Backend/.gitignore (1)
7-10: LGTM! Good practice to ignore ChromaDB artifacts.Adding ChromaDB database files and directories to .gitignore is appropriate. Database files should not be version-controlled.
Setup.md (2)
62-70: Excellent fix! Clear separation addresses issue #135.The documentation now clearly indicates that
npx react-native startandnpx react-native run-androidshould run in separate terminals, preventing the confusion described in issue #135.
118-126: Excellent fix! Clear separation for iOS workflow.Consistent with the Android section, the iOS commands are now properly separated into two terminals, making it clear that the Metro bundler and iOS build need to run concurrently.
Frontend/ios/BabyNest/PrivacyInfo.xcprivacy (1)
9-12: All three reason codes are valid per Apple's privacy manifest requirements.35F9.1 (SystemBootTime), C617.1 (FileTimestamp), and 85F4.1 (DiskSpace) are legitimate codes. However:
- The .gitignore contradiction claim appears unsupported—PrivacyInfo.xcprivacy is not present in Frontend/.gitignore or the root .gitignore.
- The reordering claim cannot be verified; the file already shows the stated final order (SystemBootTime → UserDefaults → FileTimestamp → DiskSpace).
- Verify that these APIs are actually used in the app code and that the UserDefaults category (CA92.1) is also intentional, as it appears in the manifest but was not mentioned in this review.
Likely an incorrect or invalid review comment.
…ixed together in one block #135
Closes #135
📝 Description
🔧 Changes Made
📷 Screenshots or Visual Changes (if applicable)
🤝 Collaboration
Collaborated with:
@username(optional)✅ Checklist
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.