Skip to content

Conversation

@DeveloperAmrit
Copy link

@DeveloperAmrit DeveloperAmrit commented Dec 29, 2025

…ixed together in one block #135

modified:   Backend/.gitignore
modified:   Backend/db/chromadb/chroma.sqlite3
modified:   Frontend/.gitignore
modified:   Frontend/android/gradlew
modified:   Frontend/ios/BabyNest/PrivacyInfo.xcprivacy
modified:   Frontend/ios/Podfile.lock
modified:   Setup.md

Closes #135

📝 Description

🔧 Changes Made

📷 Screenshots or Visual Changes (if applicable)

🤝 Collaboration

Collaborated with: @username (optional)

✅ Checklist

  • I have read the contributing guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if applicable).
  • Any dependent changes have been merged and published in downstream modules.

Summary by CodeRabbit

  • Chores

    • Updated development ignore rules to exclude ChromaDB database files, Android build artifacts, iOS dependencies, and related configuration files
    • Modified iOS privacy access declarations with updated API type categorizations
  • Documentation

    • Updated development setup instructions with clarified two-terminal workflow for both Android and iOS platforms, separating the Metro bundler startup from the app deployment process

✏️ Tip: You can customize this high-level summary in your review settings.

…parately mixed together in one block AOSSIE-Org#135

	modified:   Backend/.gitignore
	modified:   Backend/db/chromadb/chroma.sqlite3
	modified:   Frontend/.gitignore
	modified:   Frontend/android/gradlew
	modified:   Frontend/ios/BabyNest/PrivacyInfo.xcprivacy
	modified:   Frontend/ios/Podfile.lock
	modified:   Setup.md
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Walkthrough

This PR updates documentation to separate concurrent terminal commands into distinct workflows for Android and iOS setup, adds ChromaDB artifacts to backend gitignore, updates frontend gitignore with platform-specific entries, and modifies iOS privacy API declarations.

Changes

Cohort / File(s) Summary
Backend & Frontend .gitignore Configuration
Backend/.gitignore, Frontend/.gitignore
Backend: Added ChromaDB-related artifacts (\*.sqlite3, db/chromadb/, my_chroma_db/). Frontend: Added PrivacyInfo.xcprivacy, android/gradlew files, and ios/Podfile.lock entries.
iOS Privacy Configuration
Frontend/ios/BabyNest/PrivacyInfo.xcprivacy
Reordered NSPrivacyAccessedAPIType entries (FileTimestamp ↔ SystemBootTime with corresponding reason codes C617.1 ↔ 35F9.1) and added new NSPrivacyAccessedAPICategoryDiskSpace with reason 85F4.1.
Setup Documentation
Setup.md
Restructured Android and iOS run sections to explicitly separate Metro start (npx react-native start) and run commands (npx react-native run-android/run-ios) into two-terminal workflows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Updated setup documentation #89: Also modifies Setup.md to separate Metro start and run commands, and addresses ChromaDB-related artifacts in the backend configuration.

Poem

🐰 Two terminals better than one, they say,
ChromaDB tucks away to hide and play,
Privacy reasons shuffled all around,
iOS builds faster on this coding ground! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning Changes to Backend/.gitignore, Frontend/.gitignore, and PrivacyInfo.xcprivacy are out of scope; issue #135 specifically requires only Setup.md documentation updates. Remove unrelated .gitignore modifications and PrivacyInfo.xcprivacy changes. Keep only Setup.md updates that address the two-terminal workflow separation requirement from issue #135.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly identifies the main change as fixing issue #135 by updating documentation to separate commands that should run in different terminals.
Linked Issues check ✅ Passed The PR addresses the core requirement from issue #135 by separating commands into two-terminal workflows in Setup.md, though additional unrelated changes to .gitignore and PrivacyInfo.xcprivacy files are included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Removed Android gradlew files and iOS Podfile.lock from .gitignore.
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2d9f82 and 24ad266.

⛔ Files ignored due to path filters (1)
  • Frontend/ios/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • Backend/.gitignore
  • Backend/db/chromadb/chroma.sqlite3
  • Frontend/.gitignore
  • Frontend/android/gradlew
  • Frontend/ios/BabyNest/PrivacyInfo.xcprivacy
  • Setup.md
🔇 Additional comments (4)
Backend/.gitignore (1)

7-10: LGTM! Good practice to ignore ChromaDB artifacts.

Adding ChromaDB database files and directories to .gitignore is appropriate. Database files should not be version-controlled.

Setup.md (2)

62-70: Excellent fix! Clear separation addresses issue #135.

The documentation now clearly indicates that npx react-native start and npx react-native run-android should run in separate terminals, preventing the confusion described in issue #135.


118-126: Excellent fix! Clear separation for iOS workflow.

Consistent with the Android section, the iOS commands are now properly separated into two terminals, making it clear that the Metro bundler and iOS build need to run concurrently.

Frontend/ios/BabyNest/PrivacyInfo.xcprivacy (1)

9-12: All three reason codes are valid per Apple's privacy manifest requirements.

35F9.1 (SystemBootTime), C617.1 (FileTimestamp), and 85F4.1 (DiskSpace) are legitimate codes. However:

  1. The .gitignore contradiction claim appears unsupported—PrivacyInfo.xcprivacy is not present in Frontend/.gitignore or the root .gitignore.
  2. The reordering claim cannot be verified; the file already shows the stated final order (SystemBootTime → UserDefaults → FileTimestamp → DiskSpace).
  3. Verify that these APIs are actually used in the app code and that the UserDefaults category (CA92.1) is also intentional, as it appears in the manifest but was not mentioned in this review.

Likely an incorrect or invalid review comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOCS UPDATE: Commands supposed to run separately mixed together in one block

1 participant