-
Notifications
You must be signed in to change notification settings - Fork 87
Update Readme: added the info for the functions not defined in the readme, Fixes #122 #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughSeven new function entries were added to the README file, documenting functions for story notifications, friend calls, and Meilisearch synchronization tasks. Each entry includes a function path label and descriptive purpose statement. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
44-56: Remove blank lines to maintain consistent formatting with existing entries.The new function entries have blank lines interspersed between them, whereas the existing entries (a-j) are formatted without blank lines. This creates a visual inconsistency in the documentation.
Remove the blank lines on 45, 47, 49, 51, 53, and 55 to align with the existing formatting style.
(k) [send-story-notification](functions/send-story-notification/) : Function to send notifications when stories are posted or updated (notifies followers or relevant users). - (l) [start-friend-call](functions/start-friend-call/) : Function to initiate a direct friend-to-friend voice call, creating/joining LiveKit sessions and updating call records. - (m) [sync-all-documents-with-meilisearch](functions/sync-all-documents-with-meilisearch/) : Function to synchronize all relevant database collections and documents with Meilisearch indices for global search availability. - (n) [sync-stories-with-meilisearch](functions/sync-stories-with-meilisearch/) : Function to keep story documents in sync with the Meilisearch index so stories are searchable. - (o) [sync-users-with-meilisearch](functions/sync-users-with-meilisearch/) : Function to index and synchronize user documents with Meilisearch for user search and discovery. - (p) [upcomingRoom-isTime-checker](functions/upcomingRoom-isTime-checker/) : Cron function to check scheduled upcoming rooms and activate or mark them ready when their start time is near. - (q) [upcomingRoom-Message-Notification](functions/upcomingRoom-Message-Notification/) : Function to send reminders/notifications to users about upcoming rooms (e.g., reminders before start time).Please verify that the function paths (e.g.,
functions/send-story-notification/,functions/start-friend-call/) match the actual function directories in the repository.
|
Hey @M4dhav please have a look at the PR and consider merging it if everything seems fine. If there are still any changes you like, please do guide me through them. |
As per the requested missing fields in the Issue #122 I have added the definitions of the functions that were previously missing.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.