-
Notifications
You must be signed in to change notification settings - Fork 319
feat(i18n): complete missing translations for Gujarati, Kannada, and … #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): complete missing translations for Gujarati, Kannada, and … #690
Conversation
…Marathi Added 61 translations across three Indian languages: - Gujarati (31): room search, management, and Whisper AI model strings - Kannada (15): room search and management strings - Marathi (15): room search and management strings All strings now properly localized in native scripts. Resolves user experience issues for non-English speakers in India. Closes AOSSIE-Org#688
|
🎉 Welcome @Muneerali199!
We appreciate your contribution! 🚀 |
📝 WalkthroughWalkthroughMissing translations across Gujarati, Kannada, and Marathi localization files have been completed. English string literals for UI labels, error messages, room management actions, and search functionality were replaced with native language equivalents. No functional logic or method signatures were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
lib/l10n/app_localizations_kn.dart (1)
567-567: Untranslated string:searchFailedstill contains English text.The
searchFailedgetter at Line 567 returns English text'Failed to search rooms. Please try again.'while a similar gettersearchRoomsError(lines 752-753) has been properly translated to Kannada. This is inconsistent with the PR objective to complete missing translations.Verify whether
searchFailedshould also be translated or if it serves a different purpose thansearchRoomsError.lib/l10n/app_localizations_mr.dart (1)
564-564: Untranslated string:searchFailedstill contains English text.Similar to the Kannada localization, the
searchFailedgetter at Line 564 returns English text whilesearchRoomsError(lines 750-751) has been properly translated to Marathi. This should be addressed for consistency.lib/l10n/app_localizations_gu.dart (1)
562-562: Untranslated string:searchFailedstill contains English text.The
searchFailedgetter at Line 562 returns English text whilesearchRoomsError(line 747) has been properly translated to Gujarati. This inconsistency appears across all three language files in this PR.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
lib/l10n/app_localizations_gu.dartlib/l10n/app_localizations_kn.dartlib/l10n/app_localizations_mr.dart
🔇 Additional comments (5)
lib/l10n/app_localizations_kn.dart (2)
320-370: LGTM! Whisper AI model translations look complete.The translations for app preferences and all Whisper model variants (Tiny, Base, Small, Medium, Large V1, Large V2) along with their descriptions are properly localized in Kannada. The Unicode encoding appears correct.
398-408: LGTM! Room management and search translations are properly localized.The translations for room hiding/removal actions and search functionality have been correctly added in Kannada with proper Unicode encoding. The terminology appears consistent across related strings.
Also applies to: 740-763, 1272-1276
lib/l10n/app_localizations_mr.dart (1)
398-408: LGTM! Marathi translations for room management and search are correct.The Marathi translations for room actions and search functionality use proper Devanagari script encoding and maintain consistent terminology.
Also applies to: 738-761, 1266-1270
lib/l10n/app_localizations_gu.dart (2)
320-369: LGTM! Excellent approach to Whisper model translations.The Gujarati translations for Whisper AI models are well done. Including the English model names in parentheses (e.g., "નાનું (Tiny)", "બેસ (Base)") is a helpful practice that maintains clarity while providing native language translations.
396-406: LGTM! Gujarati translations for room management and search are comprehensive.The translations use proper Gujarati script encoding and cover all the required room management and search functionality strings as outlined in issue #688.
Also applies to: 735-757, 1263-1267
M4dhav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are directly in the app_localizations files, these are auto generated and should never be manually edited. Please go through Translations.MD to see how to add translations
|
Please change the base branch of the PR to dev. And for future reference, please note that all PRs must be raised to dev, and the PR template must be followed |
|
Ok sir @M4dhav > |
|
@M4dhav I've followed your guidance and created a new PR with the correct approach: ✅ Edited ARB source files (not auto-generated dart files) New PR: #692 Closing this PR as it used the wrong approach. Thank you for the feedback! |
|
✅ PR Closed - Thank You, @Muneerali199!
We appreciate your effort and look forward to more contributions from you! 🤝 |
Description
Completes missing i18n translations for three Indian languages, ensuring consistent localization across the app for Gujarati, Kannada, and Marathi speakers.
Changes
cleargetter definition in Kannada localizationTesting
flutter analyzepasses with no errorsImpact
Resolves UX issues where English strings were displayed instead of native language text for 300M+ users in India.
Closes #688
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.