Skip to content

Conversation

@Muneerali199
Copy link

@Muneerali199 Muneerali199 commented Jan 6, 2026

Description

Completes missing i18n translations for three Indian languages, ensuring consistent localization across the app for Gujarati, Kannada, and Marathi speakers.

Changes

  • Added 31 Gujarati translations (app preferences, Whisper AI models, room search/management)
  • Added 15 Kannada translations (room search and management features)
  • Added 15 Marathi translations (room search and management features)
  • Fixed duplicate clear getter definition in Kannada localization

Testing

  • ✅ All translations use proper Unicode encoding
  • flutter analyze passes with no errors
  • ✅ Translations follow existing pattern and Hindi reference
  • ✅ No duplicate definitions

Impact

Resolves UX issues where English strings were displayed instead of native language text for 300M+ users in India.

Closes #688

Summary by CodeRabbit

  • Localization
    • Added and updated translations for Gujarati, Kannada, and Marathi languages. Enhanced language support now covers UI labels, status messages, room management actions, search functionality, and user prompts throughout the application.

✏️ Tip: You can customize this high-level summary in your review settings.

…Marathi

Added 61 translations across three Indian languages:
- Gujarati (31): room search, management, and Whisper AI model strings
- Kannada (15): room search and management strings
- Marathi (15): room search and management strings

All strings now properly localized in native scripts.
Resolves user experience issues for non-English speakers in India.

Closes AOSSIE-Org#688
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

🎉 Welcome @Muneerali199!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

Missing translations across Gujarati, Kannada, and Marathi localization files have been completed. English string literals for UI labels, error messages, room management actions, and search functionality were replaced with native language equivalents. No functional logic or method signatures were modified.

Changes

Cohort / File(s) Summary
Indian Language Localizations
lib/l10n/app_localizations_gu.dart, lib/l10n/app_localizations_kn.dart, lib/l10n/app_localizations_mr.dart
String translations updated from English to Gujarati, Kannada, and Marathi respectively. Includes room management (hide, removeRoom, removeRoomFromList, removeRoomConfirmation, failedToRemoveRoom, roomRemovedSuccessfully), search functionality (searchRooms, searchingRooms, clearSearch, searchError, searchRoomsError, search, clear), and UI labels. Gujarati file also includes Whisper AI model descriptions and app preferences translations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #550: Gujarati localization implementation—modifies the same app_localizations_gu.dart file with related localization setup and structure.
  • PR #583: Kannada localization resources—affects the same app_localizations_kn.dart file with Kannada translation infrastructure.
  • PR #572: Marathi localization updates—directly overlaps with changes to app_localizations_mr.dart and AppLocalizationsMr registration.

Suggested labels

translations

Suggested reviewers

  • M4dhav

Poem

🐰 Across Gujarat, Karnataka, and Maharashtra plains,
Three languages now bloom in the UI's veins,
No English in sight, just native tongues bright—
A hundred million voices reunite!

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates the PR completes missing translations for three Indian language localizations, which matches the primary objective of adding translations for Gujarati, Kannada, and Marathi.
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #688: adds 31 Gujarati translations (including 16 Whisper AI strings), 15 Kannada translations, and 15 Marathi translations covering room search/management and transcription features.
Out of Scope Changes check ✅ Passed All changes are strictly focused on localization string translations for the three specified languages with no functional logic modifications or unrelated alterations present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b063ecb and b84fedc.

📒 Files selected for processing (3)
  • lib/l10n/app_localizations_gu.dart
  • lib/l10n/app_localizations_kn.dart
  • lib/l10n/app_localizations_mr.dart
🔇 Additional comments (5)
lib/l10n/app_localizations_kn.dart (2)

320-370: LGTM! Whisper AI model translations look complete.

The translations for app preferences and all Whisper model variants (Tiny, Base, Small, Medium, Large V1, Large V2) along with their descriptions are properly localized in Kannada. The Unicode encoding appears correct.


398-408: LGTM! Room management and search translations are properly localized.

The translations for room hiding/removal actions and search functionality have been correctly added in Kannada with proper Unicode encoding. The terminology appears consistent across related strings.

Also applies to: 740-763, 1272-1276

lib/l10n/app_localizations_mr.dart (1)

398-408: LGTM! Marathi translations for room management and search are correct.

The Marathi translations for room actions and search functionality use proper Devanagari script encoding and maintain consistent terminology.

Also applies to: 738-761, 1266-1270

lib/l10n/app_localizations_gu.dart (2)

320-369: LGTM! Excellent approach to Whisper model translations.

The Gujarati translations for Whisper AI models are well done. Including the English model names in parentheses (e.g., "નાનું (Tiny)", "બેસ (Base)") is a helpful practice that maintains clarity while providing native language translations.


396-406: LGTM! Gujarati translations for room management and search are comprehensive.

The translations use proper Gujarati script encoding and cover all the required room management and search functionality strings as outlined in issue #688.

Also applies to: 735-757, 1263-1267


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
lib/l10n/app_localizations_kn.dart (1)

567-567: Untranslated string: searchFailed still contains English text.

The searchFailed getter at Line 567 returns English text 'Failed to search rooms. Please try again.' while a similar getter searchRoomsError (lines 752-753) has been properly translated to Kannada. This is inconsistent with the PR objective to complete missing translations.

Verify whether searchFailed should also be translated or if it serves a different purpose than searchRoomsError.

lib/l10n/app_localizations_mr.dart (1)

564-564: Untranslated string: searchFailed still contains English text.

Similar to the Kannada localization, the searchFailed getter at Line 564 returns English text while searchRoomsError (lines 750-751) has been properly translated to Marathi. This should be addressed for consistency.

lib/l10n/app_localizations_gu.dart (1)

562-562: Untranslated string: searchFailed still contains English text.

The searchFailed getter at Line 562 returns English text while searchRoomsError (line 747) has been properly translated to Gujarati. This inconsistency appears across all three language files in this PR.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b063ecb and b84fedc.

📒 Files selected for processing (3)
  • lib/l10n/app_localizations_gu.dart
  • lib/l10n/app_localizations_kn.dart
  • lib/l10n/app_localizations_mr.dart
🔇 Additional comments (5)
lib/l10n/app_localizations_kn.dart (2)

320-370: LGTM! Whisper AI model translations look complete.

The translations for app preferences and all Whisper model variants (Tiny, Base, Small, Medium, Large V1, Large V2) along with their descriptions are properly localized in Kannada. The Unicode encoding appears correct.


398-408: LGTM! Room management and search translations are properly localized.

The translations for room hiding/removal actions and search functionality have been correctly added in Kannada with proper Unicode encoding. The terminology appears consistent across related strings.

Also applies to: 740-763, 1272-1276

lib/l10n/app_localizations_mr.dart (1)

398-408: LGTM! Marathi translations for room management and search are correct.

The Marathi translations for room actions and search functionality use proper Devanagari script encoding and maintain consistent terminology.

Also applies to: 738-761, 1266-1270

lib/l10n/app_localizations_gu.dart (2)

320-369: LGTM! Excellent approach to Whisper model translations.

The Gujarati translations for Whisper AI models are well done. Including the English model names in parentheses (e.g., "નાનું (Tiny)", "બેસ (Base)") is a helpful practice that maintains clarity while providing native language translations.


396-406: LGTM! Gujarati translations for room management and search are comprehensive.

The translations use proper Gujarati script encoding and cover all the required room management and search functionality strings as outlined in issue #688.

Also applies to: 735-757, 1263-1267

Copy link
Contributor

@M4dhav M4dhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are directly in the app_localizations files, these are auto generated and should never be manually edited. Please go through Translations.MD to see how to add translations

@M4dhav
Copy link
Contributor

M4dhav commented Jan 6, 2026

Please change the base branch of the PR to dev. And for future reference, please note that all PRs must be raised to dev, and the PR template must be followed

@Muneerali199
Copy link
Author

Muneerali199 commented Jan 6, 2026

Ok sir @M4dhav >

@Muneerali199
Copy link
Author

@M4dhav I've followed your guidance and created a new PR with the correct approach:

✅ Edited ARB source files (not auto-generated dart files)
✅ Used proper Unicode encoding
✅ Targeted dev branch as required
✅ Ran flutter gen-l10n to generate localization files

New PR: #692

Closing this PR as it used the wrong approach. Thank you for the feedback!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

PR Closed - Thank You, @Muneerali199!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Missing Translations in Localization Files

2 participants