GCS ACLE #364
Merged
GCS ACLE #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The only difference compared to #260 is use of non-const type for GCS pointer (an relevant change in wording). |
DanielKristofKiss
approved these changes
Nov 25, 2024
Contributor
DanielKristofKiss
left a comment
DanielKristofKiss
left a comment
There was a problem hiding this comment.
+1 from me, just a note from me.
let see what others says.
Co-authored-by: Yury Khrustalev <yury.khrustalev@arm.com>
yury-khrustalev
force-pushed
the
gcs
branch
2 times, most recently
from
70ac9c6 to
a6e18dd
Compare
Co-authored-by: Yury Khrustalev <yury.khrustalev@arm.com>
|
LGTM |
philgee-oss
reviewed
Feb 18, 2025
sivan-shani
added a commit
to sivan-shani/llvm-project
that referenced
this pull request
Apr 23, 2025
The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
sivan-shani
added a commit
to sivan-shani/llvm-project
that referenced
this pull request
Apr 23, 2025
The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
sivan-shani
added a commit
to llvm/llvm-project
that referenced
this pull request
Apr 24, 2025
#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 6, 2025
…pecification (#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
llvm#136850) The original __gcsss intrinsic was implemented based on: ARM-software/acle#260 with the signature: const void *__gcsss(const void *) Per the updated specification in: ARM-software/acle#364 both const qualifiers have been removed. This commit updates the signature accordingly to: void *__gcsss(void *) This aligns the implementation with the latest ACLE definition.
Member
|
@all-contributors please add @yury-khrustalev for code. |
Contributor
|
I've put up a pull request to add @yury-khrustalev! 🎉 |
vhscampos
added a commit
that referenced
this pull request
Jun 6, 2025
Adds @yury-khrustalev as a contributor for code. This was requested by vhscampos [in this comment](#364 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Victor Campos <victor.campos@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to continue discussion started in #260.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.