Add threading to host-side Python comms server #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds multi-threading support to the Python communications server, enabling concurrent access from multiple layer clients. Previously, the server handled connections serially; now each client connection runs in its own worker thread.
Key Changes:
- Converted server from single-threaded to multi-threaded architecture with one thread per client connection
- Refactored socket handling to pass
sockdas parameter instead of instance variable - Added worker thread pool management with proper cleanup on shutdown
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lglpy/comms/server.py | Implements threading per client connection, refactors socket handling methods to static methods with explicit socket parameters, adds worker thread management |
| lgl_android_install.py | Passes verbose flag to service constructors for consistent logging behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This enables multiple layers to connect to the server and make use of host-side services.
solidpixel
force-pushed
the
server_threads
branch
from
1dbb4c3 to
531324d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Python server than runs on the host, providing services to layers, multi-threaded with a single thread per connected client layer. This allows multiple layers to use host-side services concurrently.