Skip to content

Fix device sleep issue for jankbench workload #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robF8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix device sleep issue for jankbench workload #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wa/workloads/jankbench/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import sqlite3
import subprocess
import sys
import time
from copy import copy

import pandas as pd
Expand Down Expand Up @@ -143,9 +144,8 @@ def extract_metrics_from_db(self, context): # pylint: disable=no-self-use
janks_pc,
], axis=1)
results.columns = ['mean', 'std_dev', 'count_jank', 'jank_p']

for test_name, rep in results.index:
test_results = results.ix[test_name, rep]
test_results = results.loc[test_name, rep]
for metric, value in test_results.items():
context.add_metric(metric, value, units=None, lower_is_better=True,
classifiers={'test_name': test_name, 'rep': rep})
Expand Down Expand Up @@ -218,7 +218,7 @@ def run(self):
proc = subprocess.Popen(self.command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
while not self.stop_event.is_set():
if self.run_ended.is_set():
self.target.sleep(DELAY)
time.sleep(DELAY)
else:
ready, _, _ = select.select([proc.stdout, proc.stderr], [], [], 2)
if ready:
Expand Down