Deps update semver #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support incrementing prerelease and build flags
add a couple of extra tests have to clear the config as it's operating as a global with mutable dicts - fine in CLI but breaks in tests
gives better handling of situation where user is starting from `0.0.0` with no tags.
whereas glob returns files relative to cwd
example config for `trigger_patterns`:
```
"newsfiles/*.bugfix": "patch",
"newsfiles/*.doc": "patch",
"newsfiles/*.feature": "minor",
"newsfiles/*.major": "major",
"newsfiles/*.minor": "minor",
"newsfiles/*.patch": "patch",
"newsfiles/*.removal": "major",
```
changes the cli
Previously, the `new_version` was printed, which included prerelease tags, even if the `--release` flag was passed. This seemed wrong, but does change the behaviour - if the prerelease version is needed on stdout, don't pass the `--release` flag.
previously, tag templates like `v{version}` would end up looking like
`^(.*)v$`
Because the `10*v` is position-invariant and `.replace` replaces the first match. Using a position-specific string (like, any string with a variety of characters ...) resolves this issue.
Bugfix/bad placeholder (SANE-484)
davidhyman
force-pushed
the
deps-update-semver
branch
from
f21230a to
51a5a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the
semverdependency; let's see if the tests are happy now.It now supports some of the features we were doing in
autoversion, so might replace theSemVerSigFigcode - but that's for a later PR.