Fix for min_bursts not checking each swath#209
Open
a-diab wants to merge 2 commits intoASFHyP3:developfrom
Open
Fix for min_bursts not checking each swath#209a-diab wants to merge 2 commits intoASFHyP3:developfrom
a-diab wants to merge 2 commits intoASFHyP3:developfrom
Conversation
* Fixed min bursts not checking for each swath
* adds --remove-duplicate-bursts to burst2safe which checks for multiple bursts with the same burst id and only uses a set with the same size * add removing duplicates output * - adds docs - removes prints - keeps largest burst in case of duplicates * bug fixes --------- Co-authored-by: Charlie <charlie.wadds@terramotioncanada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using burst2safe with the min_bursts option, only the total number of bursts gets checked against min_bursts.
The example below will download 2 bursts in the first swath and only 1 burst in the second, causing issues in ESD processing.
Fixing it will ensure each swath has the min_bursts specified.