-
Couldn't load subscription status.
- Fork 84
Mujoco System Mass Matrix Module #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
cbcdddc to
0eea9ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments to address. Otherwise good to go.
src/simulation/mujocoDynamics/MJSystemMassMatrix/MJSystemMassMatrix.rst
Outdated
Show resolved
Hide resolved
0eea9ec to
f07d39e
Compare
|
@Will-Schwend , feel free to push this PR if @juan-g-bonilla has no issues with your implementation to interface with his code. |
f07d39e to
debf501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks for putting in the work to make this a general useful component.
src/simulation/mujocoDynamics/MJSystemMassMatrix/MJSystemMassMatrix.h
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/MJSystemMassMatrix.h
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/MJSystemMassMatrix.h
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/_UnitTest/test_MJSystemMassMatrix.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/_UnitTest/test_MJSystemMassMatrix.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/_UnitTest/test_MJSystemMassMatrix.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/_UnitTest/test_MJSystemMassMatrix.py
Outdated
Show resolved
Hide resolved
src/simulation/mujocoDynamics/MJSystemMassMatrix/_UnitTest/test_MJSystemMassMatrix.py
Outdated
Show resolved
Hide resolved
e3a0491 to
5766cf6
Compare
5766cf6 to
aefa98f
Compare
Description
This PR adds the ability to extract the system mass matrix and number of degrees of freedom from a Mujoco scene with a single spacecraft. This enables the use of these values throughout other Basilisk modules.
Verification
A new unit test
test_MJSystemMassMatrix.pywas created which verifies the degrees of freedom and mass matrix extracted in the moduleDocumentation
New documentation was made for the
MJSystemMassMatrixmodule. Reslease notes were updated to include the new module.Future work
N/A