Skip to content

Conversation

@Will-Schwend
Copy link
Contributor

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR adds the ability to extract the system mass matrix and number of degrees of freedom from a Mujoco scene with a single spacecraft. This enables the use of these values throughout other Basilisk modules.

Verification

A new unit test test_MJSystemMassMatrix.py was created which verifies the degrees of freedom and mass matrix extracted in the module

Documentation

New documentation was made for the MJSystemMassMatrix module. Reslease notes were updated to include the new module.

Future work

N/A

@Will-Schwend Will-Schwend self-assigned this Sep 22, 2025
@Will-Schwend Will-Schwend requested a review from a team as a code owner September 22, 2025 16:29
@Will-Schwend Will-Schwend added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2025
@Will-Schwend Will-Schwend moved this to 👀 In review in Basilisk Sep 22, 2025
@Will-Schwend Will-Schwend force-pushed the feature/Mujoco-System-Mass-Matrix branch from cbcdddc to 0eea9ec Compare September 23, 2025 19:02
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments to address. Otherwise good to go.

@Will-Schwend Will-Schwend force-pushed the feature/Mujoco-System-Mass-Matrix branch from 0eea9ec to f07d39e Compare September 26, 2025 17:06
@schaubh
Copy link
Contributor

schaubh commented Sep 29, 2025

@Will-Schwend , feel free to push this PR if @juan-g-bonilla has no issues with your implementation to interface with his code.

@Will-Schwend Will-Schwend force-pushed the feature/Mujoco-System-Mass-Matrix branch from f07d39e to debf501 Compare September 29, 2025 17:25
Copy link
Contributor

@juan-g-bonilla juan-g-bonilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks for putting in the work to make this a general useful component.

@Will-Schwend Will-Schwend marked this pull request as draft October 24, 2025 17:07
@Will-Schwend Will-Schwend force-pushed the feature/Mujoco-System-Mass-Matrix branch 2 times, most recently from e3a0491 to 5766cf6 Compare October 28, 2025 21:01
@Will-Schwend Will-Schwend force-pushed the feature/Mujoco-System-Mass-Matrix branch from 5766cf6 to aefa98f Compare October 29, 2025 21:57
@Will-Schwend Will-Schwend marked this pull request as ready for review October 29, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

4 participants