fix(core): add override modifier to HttpError.message property#53
Closed
halotukozak wants to merge 2 commits intomasterfrom
Closed
fix(core): add override modifier to HttpError.message property#53halotukozak wants to merge 2 commits intomasterfrom
halotukozak wants to merge 2 commits intomasterfrom
Conversation
Generated HttpError extends RuntimeException but its `message` property was missing the `override` modifier, causing compilation failures in downstream projects. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a pre-existing codegen compilation issue where the generated HttpError data class defines a message property while extending RuntimeException, but did not mark the property as an override, causing downstream compilation failures.
Changes:
- Add
overridemodifier to the generatedHttpError.messageproperty inApiResponseGenerator.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
|
Resolve conflict in ApiResponseGenerator.kt by accepting master's sealed HttpError class with body property. The branch's override fix on the message property is no longer needed since master replaced the RuntimeException-based HttpError data class with a sealed class hierarchy that has no message property. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpErrorextendsRuntimeExceptionbut itsmessageproperty was missing theoverridemodifierTest plan
plugin:functionalTestpasses (was failing on master)core:testpasses🤖 Generated with Claude Code