Introduce new gh acction for jacoco comment #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fake change to see result.
|
JaCoCo code coverage report - Scala 2.11
No changed file in report. |
|
JaCoCo code coverage report - Scala 2.12
No changed file in report. |
benedeki
reviewed
Apr 1, 2025
.github/workflows/check-jacoco.yml
Outdated
| core.setFailed('Changed files coverage is less than 80%!') | ||
| sensitivity: "detail" | ||
| comment-mode: 'single' | ||
| min-coverage-overall: 80.0 |
Contributor
There was a problem hiding this comment.
You changed the overall coverage from 0% to 80%. That can be quite restrictive. Is it justified?
Contributor
Author
There was a problem hiding this comment.
I see. I will set it to 75% as min. It should be passing. See commit - 2efb63c.
|
benedeki
approved these changes
Apr 1, 2025
dk1844
approved these changes
Apr 1, 2025
miroslavpojer
deleted the
feature/136-Introduced-new-gh-action---jacoco-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Closes #136