Skip to content

#2229: XML reading larger files gets records lost occassionally #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benedeki merged 2 commits into from
Sep 1, 2025
Merged

#2229: XML reading larger files gets records lost occassionally #2230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cced18e
#2229: XML reading larger files gets records lost occasionally
benedeki Aug 25, 2025
c0ad7a2
* allowed warnings in Spark-jobs module
benedeki Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ ___
- [Conformance](#conformance)
- [How to build](#how-to-build)
- [How to run](#how-to-run)
- [How to release](#how-to-release)
- [Plugins](#plugins)
- [Built-in Plugins](#built-in-plugins)
- [How to contribute](#how-to-contribute)
Expand Down Expand Up @@ -311,7 +312,7 @@ The list of additional options available for running Standardization:

Most of these options are format specific. For details see [the documentation](https://absaoss.github.io/enceladus/docs/usage/standardization-formats).

<sup>*</sup> Can also be specified as a unicode value in the following ways: <code>U+00A1</code>, <code>u00a1</code> or just the code <code>00A1</code>. In case empty string option needs to be applied, the keyword <code>none</code> can be used.
<sup>*</sup> Can also be specified as a Unicode value in the following ways: <code>U+00A1</code>, <code>u00a1</code> or just the code <code>00A1</code>. In case empty string option needs to be applied, the keyword <code>none</code> can be used.

The list of additional options available for running Conformance:

Expand All @@ -324,6 +325,10 @@ The list of additional options available for running Conformance:

All the additional options valid for both Standardization and Conformance can also be specified when running the combined StandardizationAndConformance job

## How to release

See the detailed document in [scripts/release/README.md](scripts/release/README.md).

## Plugins

Standardization and Conformance support plugins that allow executing additional actions at certain times of the computation.
Expand Down
44 changes: 40 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,13 @@
<dockerfile.maven.version>1.4.13</dockerfile.maven.version>
<gitflow.maven.plugin.version>1.16.0</gitflow.maven.plugin.version>
<maven.antrun.plugin.version>1.8</maven.antrun.plugin.version>
<maven.central.publishing.plugin.version>0.8.0</maven.central.publishing.plugin.version>
<maven.gpg.plugin.version>1.6</maven.gpg.plugin.version>
<maven.jar.plugin.version>3.2.0</maven.jar.plugin.version>
<maven.rat.plugin.version>0.12</maven.rat.plugin.version>
<maven.resources.plugin.version>3.1.0</maven.resources.plugin.version>
<maven.shade.plugin.version>3.2.1</maven.shade.plugin.version>
<maven.source.plugin.version>3.0.1</maven.source.plugin.version>
<maven.source.plugin.version>3.3.1</maven.source.plugin.version>
<maven.surefire.plugin.version>2.18.1</maven.surefire.plugin.version>
<maven.war.plugin.version>2.2</maven.war.plugin.version>
<scala.maven.plugin.version>4.8.1</scala.maven.plugin.version>
Expand Down Expand Up @@ -189,7 +191,7 @@
<spark.hats.version>0.2.2</spark.hats.version>
<spark.hofs.version>0.4.0</spark.hofs.version>
<spark.version>2.4.4</spark.version>
<spark.xml.version>0.5.0</spark.xml.version>
<spark.xml.version>0.13.0</spark.xml.version>
Copy link

@ABLL526 ABLL526 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.
Just a quick question any reason to use 0.13.0 instead of something newer?

Copy link
Collaborator

@lsulak lsulak Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 0.14.0 onwards is for newer Spark (3.2.0) and Scala (2.13): https://github.com/databricks/spark-xml/releases

and here in this project it's Spark 2.4.4 and Scala 2.11, at least in the current version of Enceladus this PR is trying to enhance

<specs.version>2.4.16</specs.version>
<spline.version>0.3.9</spline.version>
<spray.json.version>1.3.5</spray.json.version>
Expand Down Expand Up @@ -400,7 +402,7 @@
<filereports>WDF TestSuite.txt</filereports>
<!--
Set heap memory to 4000 MB so array conformance test and conformance
end to end test could run. This can be removed later when dynamic conformance
end-to-end test could run. This can be removed later when dynamic conformance
becomes more efficient
-->
<argLine>-Xmx4000m -Dfile.encoding=UTF-8</argLine>
Expand Down Expand Up @@ -462,7 +464,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.1.0</version>
<version>${maven.resources.plugin.version}</version>
<configuration>
<delimiters>
<delimiter>@</delimiter>
Expand All @@ -478,6 +480,30 @@
<aggregate>true</aggregate>
</configuration>
</plugin>
<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<version>${maven.central.publishing.plugin.version}</version>
<extensions>true</extensions>
<configuration>
<publishingServerId>central</publishingServerId>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>${maven.rat.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${maven.source.plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>${maven.gpg.plugin.version}</version>
</plugin>
</plugins>
<resources>
<resource>
Expand Down Expand Up @@ -594,6 +620,16 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<extensions>true</extensions>
<configuration>
<publishingServerId>central</publishingServerId>
<autoPublish>true</autoPublish>
<deploymentName>${project.groupId}:${project.artifactId}:${project.version}</deploymentName>
</configuration>
</plugin>
</plugins>
</build>
</profile>
Expand Down
1 change: 0 additions & 1 deletion spark-jobs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ spark-submit -(remove this)-packages org.apache.spark:spark-sql-kafka-0-10_2.11:
</executions>
<configuration>
<args>
<arg>-Xfatal-warnings</arg>
<arg>-unchecked</arg>
<arg>-deprecation</arg>
<arg>-feature</arg>
Expand Down
Loading