-
Notifications
You must be signed in to change notification settings - Fork 0
Remove template placeholders and tone down documentation #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…guage Co-authored-by: sgbaird <45469701+sgbaird@users.noreply.github.com>
…irective Co-authored-by: sgbaird <45469701+sgbaird@users.noreply.github.com>
sgbaird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot overall good. See comments for corrections
| > Python package for programmatically controlling Progressive Automations desk lifters (e.g., LG-07 modular lifting column via FLTCON) with Prefect workflow orchestration. | ||
| Control your desk lifter remotely via Prefect Cloud deployments with asynchronous execution and position polling. Perfect for laboratory automation where the desk position needs to be coordinated with other equipment. | ||
| Control desk lifters remotely via Prefect Cloud deployments with asynchronous execution and position polling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that it's specifically being used for the Progressive Automations LG-07 lifting column and may be expanded to other systems. Open a new issue if this is of interest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added specificity about LG-07 and expansion note in 2cef137
| | [AC-25](https://www.progressiveautomations.com/products/ac-25) | Table Lift Wire Extender - 4.5 feet | 2 | 5.67 USD | | ||
| | [RT-11](https://www.progressiveautomations.com/products/rt-11) | Table Lift Hand Remote - 4 Positions Memory Function | 1 | 9.99 USD | | ||
| | [FLTCON-1](https://www.progressiveautomations.com/products/fltcon-1) | Hall Effect Control Box with Presets - 110 VAC - 24 VDC - 1 Channel | 1 | 199.00 USD | | ||
| | [LG-07-3RM-32-440-HS-24V-B (black variant)](https://www.progressiveautomations.com/products/lg-07?variant=43102968447156) | 3 Stage Industrial Lifting Column - 32" Stroke - 440 lbs Force - Synchronizable - Anodic Oxide Black | 1 | 749.00 USD | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually 534.96 USD in total when you include the FLTCON-1 (should be listed), the RT-11 remote, and the (optional) Bluetooth Dongle RT-BT1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added total cost row showing 534.96 USD in 2cef137
docs/installation-and-usage.md
Outdated
|
|
||
| > **Note**: The `progressive_automations_python` CLI is provided for initial hardware testing and troubleshooting only. For production use, trigger flows via `run_deployment()` or Prefect's CLI. | ||
| ```{note} | ||
| The `progressive_automations_python` CLI is for initial hardware testing and troubleshooting. For production use, trigger flows via `run_deployment()` or Prefect's CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Append: "The package can also be used standalone, independent of Prefect."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added standalone usage note to the existing MyST note directive in 2cef137
docs/installation-and-usage.md
Outdated
| 2. Install package: `pip install progressive-automations-python` | ||
| 3. Configure Prefect Cloud: `prefect cloud login -k <api-key>` | ||
| 4. Create work pool: `prefect work-pool create desk-lifter-pool --type process` | ||
| 5. Deploy flows via Python: `create_deployments("desk-lifter-pool")` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something off here about this step. Is this from the pip package? Doesn't seem like this is CLI. Perhaps there's actually a prefect command that needs to be run in CLI to create the deployment (and maybe work pool, too)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed step 5 to proper CLI command: python -c "from progressive_automations_python.deployment import create_deployments; create_deployments('desk-lifter-pool')" in 2cef137
…te, fix deployment step Co-authored-by: sgbaird <45469701+sgbaird@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
Updated all documentation to use a muted, understated tone per issue requirements. Addressed PR review feedback:
PR Feedback Addressed:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.