-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] 자동로그인 디버깅을 위한 토큰 로그 구현 (#276) #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yurim830
wants to merge
14
commits into
develop
Choose a base branch
from
feature/#276
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bef3196
[Chore] UserDefaultsManager -> Utils로 파일명 및 폴더 변경 (#276)
yurim830 29c81b8
[Add, Feat] Token Logger 구현 (#276)
yurim830 479678a
[Add, Feat] TokenLogVC 구현 (#276)
yurim830 050abf7
[Chore] TokenLogEvent 수정 (#276)
yurim830 58d4f8c
[Chore] UserDefaults 초기화 로직에서 tokenLogs 제외 (#276)
yurim830 cdef896
[Feat] 로그 삽입 (#276)
yurim830 718640f
[Feat] TokenLogVC present 버튼 구현 (#276)
yurim830 26b666f
[Chore] TokenLogEvent 주석 추가 (#276)
yurim830 c921f6e
[Setting] 2.1.3 버전업, TestFlight 2.1.3 (build: 2025.1014.0348) (#276)
yurim830 9538616
[Add,Feat] BuildConfig 구현 (#276)
yurim830 9e311d7
[Feat] TokenLog 버튼을 디버그 및 테플 빌드에만 추가 (#276)
yurim830 c99ec3c
[Chore] 브랜치 최신화 및 컨플릭 해결 (#276)
yurim830 414e35d
[Chore] Testflight build: 2025.1014.0447 (#276)
yurim830 d1a7160
[Fix] 토큰로그 .valid 중복 제거, Testflight 배포 (#276)
yurim830 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -16,49 +16,52 @@ final class AuthManager { | |||||||
| private let refreshInterval: TimeInterval = 3 * 60 * 60 | ||||||||
|
|
||||||||
| var hasToken: Bool { | ||||||||
| return UserDefaultsManager.get(String.self, forKey: .accessToken) != nil | ||||||||
| return UserDefaultsUtils.get(String.self, forKey: .accessToken) != nil | ||||||||
| } | ||||||||
|
|
||||||||
| var hasVerifiedArea: Bool { | ||||||||
| return UserDefaultsManager.get(Bool.self, forKey: .hasVerifiedArea) ?? false | ||||||||
| return UserDefaultsUtils.get(Bool.self, forKey: .hasVerifiedArea) ?? false | ||||||||
| } | ||||||||
|
|
||||||||
| var hasPreference: Bool { | ||||||||
| return UserDefaultsManager.get(Bool.self, forKey: .hasPreference) ?? false | ||||||||
| return UserDefaultsUtils.get(Bool.self, forKey: .hasPreference) ?? false | ||||||||
| } | ||||||||
|
|
||||||||
| var hasSeenTutorial: Bool { | ||||||||
| return UserDefaultsManager.get(Bool.self, forKey: .hasSeenTutorial) ?? false | ||||||||
| return UserDefaultsUtils.get(Bool.self, forKey: .hasSeenTutorial) ?? false | ||||||||
| } | ||||||||
|
|
||||||||
| var hasSeenLocalVerification: Bool { | ||||||||
| return UserDefaultsManager.get(Bool.self, forKey: .hasSeenLocalVerification) ?? false | ||||||||
| return UserDefaultsUtils.get(Bool.self, forKey: .hasSeenLocalVerification) ?? false | ||||||||
| } | ||||||||
|
|
||||||||
| var hasSeenPreference: Bool { | ||||||||
| return UserDefaultsManager.get(Bool.self, forKey: .hasSeenPreference) ?? false | ||||||||
| return UserDefaultsUtils.get(Bool.self, forKey: .hasSeenPreference) ?? false | ||||||||
| } | ||||||||
|
|
||||||||
| func handleTokenRefresh() async throws -> Bool { | ||||||||
| let refreshToken = UserDefaultsManager.get(String.self, forKey: .refreshToken) ?? "" | ||||||||
| let refreshToken = UserDefaultsUtils.get(String.self, forKey: .refreshToken) ?? "" | ||||||||
| return try await withCheckedThrowingContinuation { continuation in | ||||||||
| ACService.shared.authService.postReissue(PostReissueRequest(refreshToken: refreshToken)) { response in | ||||||||
| switch response { | ||||||||
| case .success(let data): | ||||||||
| print("❄️ token refreshed success") | ||||||||
| UserDefaultsManager.set(data.accessToken, forKey: .accessToken) | ||||||||
| UserDefaultsManager.set(data.refreshToken, forKey: .refreshToken) | ||||||||
| UserDefaultsUtils.set(data.accessToken, forKey: .accessToken) | ||||||||
| UserDefaultsUtils.set(data.refreshToken, forKey: .refreshToken) | ||||||||
| AuthManager.shared.updateLastTokenRefreshDate() | ||||||||
| TokenLogger.shared.log(.refreshSucceeded(tokenPrefix: String(data.accessToken.prefix(10)))) | ||||||||
| continuation.resume(returning: true) | ||||||||
| case .requestErr(let error): | ||||||||
| if error.code == 40088 { | ||||||||
| print("❄️ remove token") | ||||||||
| UserDefaultsManager.removeTokens() | ||||||||
| UserDefaultsUtils.removeTokens() | ||||||||
| TokenLogger.shared.log(.refreshFailed(error: error.localizedDescription)) | ||||||||
| continuation.resume(returning: false) | ||||||||
| } else { | ||||||||
|
||||||||
| } else { | |
| } else { | |
| TokenLogger.shared.log(.refreshFailed(error: error.localizedDescription)) |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When needsTokenRefresh() returns true because lastTokenRefreshDate is nil (line 79), no token log is generated. This means the first-time login scenario after app installation won't be logged with a clear state. Consider adding TokenLogger.shared.log(.tokenExpired) or a more specific log event before returning true on line 79.
Suggested change
| guard let lastRefresh = UserDefaultsUtils.get(Date.self, forKey: .lastTokenRefreshDate) else { | |
| guard let lastRefresh = UserDefaultsUtils.get(Date.self, forKey: .lastTokenRefreshDate) else { | |
| TokenLogger.shared.log(.tokenExpired) |
18 changes: 18 additions & 0 deletions
18
ACON-iOS/ACON-iOS/Global/Settings/Config/BuildConfig.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // BuildConfig.swift | ||
| // ACON-iOS | ||
| // | ||
| // Created by 김유림 on 10/14/25. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| enum BuildConfig { | ||
|
|
||
| #if DEBUG | ||
| static let isDebug = true | ||
| #else | ||
| static let isDebug = false | ||
| #endif | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logging the first 10 characters of access tokens, even in debug/TestFlight builds, could pose a security risk. While this is limited to non-production builds, consider whether this amount of token information is necessary for debugging. A shorter prefix (e.g., 4-6 characters) or a hash of the token would be safer while still allowing token changes to be tracked.