ci: update setup-node@v1 to v4 in lint job#49
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Mar 1, 2026
Merged
Conversation
The build job already uses setup-node@v4 but the lint job was still on v1 (deprecated since 2021). This aligns both jobs on the current version.
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a0869b1 in 5 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_xNAvVvrDREz0EwII
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-nodefrom v1 to v4 in the lint jobTest plan
Important
Update
actions/setup-nodefrom v1 to v4 in thelintjob to align with thebuildjob and address deprecation.actions/setup-nodefrom v1 to v4 in thelintjob in.github/workflows/nodejs.yml.lintjob withbuildjob, which already uses v4.This description was created by
for a0869b1. You can customize this summary. It will automatically update as commits are pushed.