Skip to content

ci: update setup-node@v1 to v4 in lint job#49

Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom
TimeToBuildBob:fix/update-ci-actions
Mar 1, 2026
Merged

ci: update setup-node@v1 to v4 in lint job#49
ErikBjare merged 1 commit intoActivityWatch:masterfrom
TimeToBuildBob:fix/update-ci-actions

Conversation

@TimeToBuildBob
Copy link
Contributor

@TimeToBuildBob TimeToBuildBob commented Mar 1, 2026

Summary

  • Update actions/setup-node from v1 to v4 in the lint job
  • The build job already uses v4; this aligns both jobs on the current version
  • v1 has been deprecated since 2021

Test plan

  • CI passes (lint job runs successfully with setup-node@v4)

Important

Update actions/setup-node from v1 to v4 in the lint job to align with the build job and address deprecation.

  • CI Update:
    • Update actions/setup-node from v1 to v4 in the lint job in .github/workflows/nodejs.yml.
    • Aligns lint job with build job, which already uses v4.
    • Addresses deprecation of v1 since 2021.

This description was created by Ellipsis for a0869b1. You can customize this summary. It will automatically update as commits are pushed.

The build job already uses setup-node@v4 but the lint job was still
on v1 (deprecated since 2021). This aligns both jobs on the current
version.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a0869b1 in 5 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_xNAvVvrDREz0EwII

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@ErikBjare ErikBjare merged commit ce520e9 into ActivityWatch:master Mar 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants