feat: set aw-server-rust in default config#107
Open
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
Open
feat: set aw-server-rust in default config#1070xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
0xbrayo wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d0e49ee in 13 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw_qt/config.py:8
- Draft comment:
Ensure that 'aw-server-rust' is compatible with the rest of the system and that any dependencies or configurations required for 'aw-server-rust' are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the default configuration to use 'aw-server-rust' instead of 'aw-server'. This change is consistent across both 'aw-qt' and 'aw-qt-testing' sections. The code correctly loads the configuration based on the 'testing' flag and assigns the 'autostart_modules'.
Workflow ID: wflow_ZDDN2mZ2otmMWsa2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Member
|
Yeah, it might be time. What do you think? |
Member
Author
|
Yep, it is. I guess lots of people are not even aware of the existence of the rust server. This should help fix that. Also maybe unpin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update default configuration in
aw_qt/config.pyto useaw-server-rustinstead ofaw-server.default_configinaw_qt/config.pyto useaw-server-rustinstead ofaw-serverin both[aw-qt]and[aw-qt-testing]sections.This description was created by
for d0e49ee. It will automatically update as commits are pushed.