fix(trayicon): re-apply tooltip after show() to fix empty tooltip on Windows 11#115
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Feb 27, 2026
Conversation
…Windows 11 On Windows 11, QSystemTrayIcon tooltips set before show() may not register with the system tray backend, resulting in an empty tooltip on hover. Re-applying the tooltip text after the icon is visible ensures the platform picks it up. Fixes ActivityWatch#112
Closed
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to abde3d2 in 6 seconds. Click for details.
- Reviewed
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_KtKp81QEVnpA1T6W
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile SummaryRe-applies the tooltip text after
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: abde3d2 |
Member
|
@TimeToBuildBob merging this, fix the CI issues in separate follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trayIcon.show()to ensure the Windows system tray backend registers itshow()may not be picked up, resulting in an empty tooltip on hoverTest plan
Fixes #112
Important
Re-applies tooltip after
trayIcon.show()intrayicon.pyto fix empty tooltip issue on Windows 11.run()intrayicon.pyaftertrayIcon.show()to fix empty tooltip issue on Windows 11.This description was created by
for abde3d2. You can customize this summary. It will automatically update as commits are pushed.